feat(v7): stabilize advanced routing#13983
Open
ArmandPhilippot wants to merge 14 commits into
Open
Conversation
✅ Deploy Preview for astro-docs-2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description (required)
Updates docs to stabilize advanced routing. Kinda supersedes #13944
src/app.tsrenamingexperimental-flags/advanced-routingcontents toreferences/modules/astro-fetch.mdx(new),references/modules/astro-hono.mdx(new),guides/routing.mdx, and/en/guides/integrations-guide/cloudflare.mdx.experimental-flags/advanced-routingtranslationsMost of the content comes from
experimental-flags/advanced-routing. But I have tweaked/reworded/reorganized some parts for better integration (ie. a more guide/reference style).Happy to discuss about the organization (e.g. do we want advanced routing to be more visible?). And maybe this requires more changes, I haven't checked everything yet (e.g. Routing reference says "There is no separate routing configuration in Astro." which sounds maybe a bit outdated now).
Questions:
AstroFetchStatebe documented? I can see this is the public contract / this matches what we describe underFetchState. But doingconst state = new FetchState();returnsFetchState(the whole object, with private things) notAstroFetchState. So, I'm not sure how to integrate that.Related issues & labels (optional)
For Astro version:
7.0. See astro PR #16877.