Skip to content

iOS add title customization to scroll edge appearance #8239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
markdevocht merged 4 commits into from
Mar 5, 2026
Merged

iOS add title customization to scroll edge appearance #8239

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c567f8e
Add title customization to scroll edge appearance (#8207)
Beat-YT Feb 22, 2026
6af6024
update the missing pieces
markdevocht Feb 26, 2026
7ba2cac
Merge remote-tracking branch 'origin/master' into feat/iOS-Add-title-…
markdevocht Feb 26, 2026
d903521
Merge branch 'master' into feat/iOS-Add-title-customization-to-scroll…
markdevocht Mar 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions ios/TopBarAppearancePresenter.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,10 @@ - (void)applyOptions:(RNNTopBarOptions *)options {

[self setTitleAttributes:options.title];
[self setLargeTitleAttributes:options.largeTitle];
if (options.scrollEdgeAppearance.title && [options.scrollEdgeAppearance.title hasValue]) {
if (options.scrollEdgeAppearance.title.hasValue) {
[self setScrollEdgeTitleAttributes:options.scrollEdgeAppearance.title];
} else {
[self setScrollEdgeTitleAttributes:options.title];
}

[self setBorderColor:[options.borderColor withDefault:nil]];
Expand Down Expand Up @@ -53,6 +55,12 @@ - (void)mergeOptions:(RNNTopBarOptions *)options withDefault:(RNNTopBarOptions *
if (options.scrollEdgeAppearance.noBorder.hasValue) {
[self showScrollEdgeBorder:!options.scrollEdgeAppearance.noBorder.get];
}

if (options.scrollEdgeAppearance.title.hasValue) {
[self setScrollEdgeTitleAttributes:defaultOptions.scrollEdgeAppearance.title];
} else if (options.title.hasValue && !defaultOptions.scrollEdgeAppearance.title.hasValue) {
[self setScrollEdgeTitleAttributes:defaultOptions.title];
}
}

- (void)setTranslucent:(BOOL)translucent {
Expand Down Expand Up @@ -160,7 +168,6 @@ - (void)setTitleAttributes:(RNNTitleOptions *)titleOptions {
}

self.getAppearance.titleTextAttributes = titleTextAttributes;
self.getScrollEdgeAppearance.titleTextAttributes = titleTextAttributes;
}

- (void)setScrollEdgeTitleAttributes:(RNNTitleOptions *)titleOptions {
Expand Down