Open
Conversation
…ith AHB read of erased sector.
Fix bugs found from the update test.
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support for the NXP LPC55S69 (including TrustZone) and introduces a build-time option to avoid direct reads of erased flash sectors.
Changes:
- Added LPC55S69 HAL implementation + linker scripts, plus a dedicated test app and Makefile integration.
- Updated flash/NVM handling to optionally avoid direct reads from erased flash (
NO_DIRECT_READ_OF_ERASED_SECTOR). - Documented LPC55S69 setup/usage and added CI jobs to build the new example configs.
Reviewed changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| test-app/app_lpc55s69.c | New LPC55S69 test firmware to validate boot/update flows and LED behavior |
| test-app/Makefile | Adds lpc55s69 target build wiring and SDK object dependencies |
| test-app/ARM-lpc55s69.ld | Linker script template for LPC55S69 test app |
| test-app/ARM-lpc55s69-ns.ld | Linker script template for LPC55S69 test app (non-secure) |
| src/update_flash.c | Avoids direct reads of erased sectors during swap trailer checks |
| src/libwolfboot.c | Adds NO_DIRECT_READ_OF_ERASED_SECTOR handling across NVM trailer/magic/state logic |
| src/image.c | Avoids direct reads of erased sectors when validating image magic |
| options.mk | Introduces NO_DIRECT_READ_OF_ERASED_SECTOR build option |
| include/wolfboot/wolfboot.h | Updates image state constant(s) and retains flash erased-value constants |
| include/hal.h | Adds optional HAL hook hal_flash_is_erased_at() |
| hal/lpc55s69.ld | Linker script for LPC55S69 secure build memory layout (incl. NSC/keyvault) |
| hal/lpc55s69.c | New LPC55S69 HAL (clock init, flash ops, UART, TRNG, TrustZone setup) |
| hal/lpc55s69-ns.ld | Linker script for LPC55S69 non-secure build memory layout |
| docs/Targets.md | Adds LPC55S69 target documentation and fixes an LS1028A config filename typo |
| config/examples/lpc55s69.config | New non-TZ example config for LPC55S69 |
| config/examples/lpc55s69-tz.config | New TrustZone example config for LPC55S69 |
| arch.mk | Adds lpc55s69 target wiring (includes, flags, objects, linker selection) |
| CMakeLists.txt | Registers lpc55s69 in ARM target list |
| .github/workflows/test-configs.yml | Adds CI jobs for LPC55S69 example configs |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for NXP LPC55S69