Use TLS over transport for authentication of peer #227
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds TLS transport support to wolfHSM for secure client-server communication. The implementation extends the existing TCP transport with TLS encryption using wolfSSL, supporting both certificate-based and PSK (Pre-Shared Key) authentication methods.
Key Changes:
- New TLS transport layer built on top of TCP transport with wolfSSL integration
- Support for both mutual TLS authentication and PSK modes
- Configuration changes to enable TLS/PSK in the build system
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| port/posix/posix_transport_tls.h | Header defining TLS transport structures and function declarations |
| port/posix/posix_transport_tls.c | Implementation of TLS transport client/server functions |
| port/posix/posix_transport_tcp.c | Exposed HandleConnect function and fixed null pointer check |
| examples/posix/wh_posix_server/wh_posix_server_cfg.h | Added TLS and PSK configuration function declarations |
| examples/posix/wh_posix_server/wh_posix_server_cfg.c | Implemented TLS and PSK server configuration with certificate loading |
| examples/posix/wh_posix_server/wh_posix_server.c | Added TLS/PSK transport options to CLI |
| examples/posix/wh_posix_server/user_settings.h | Enabled TLS, TLS12, PSK, and debug settings |
| examples/posix/wh_posix_client/wh_posix_client_cfg.h | Added TLS and PSK client configuration declarations |
| examples/posix/wh_posix_client/wh_posix_client_cfg.c | Implemented TLS and PSK client configuration with certificate loading |
| examples/posix/wh_posix_client/wh_posix_client.c | Added TLS/PSK transport options to client CLI |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
JacobBarthelmeh
force-pushed
the
auth
branch
2 times, most recently
from
e9a4e7e to
fcb0a97
Compare
bigbrett
left a comment
bigbrett
left a comment
There was a problem hiding this comment.
quick initial skim - I'd like to see test coverage added to this before diving much deeper. Looks very promising though, I'm super excited about this !!!
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 18 out of 18 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 18 out of 18 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
JacobBarthelmeh
assigned
bigbrett and
JacobBarthelmeh and unassigned
JacobBarthelmeh and
bigbrett
|
Investigating SHE tests with TLS. |
|
Random thoughts for future work: It would be really cool to have a built-in way to initialize and setup the |
JacobBarthelmeh
force-pushed
the
auth
branch
from
4ab374d to
0272216
Compare
|
Rebased on top of recent examples and yaml changes. Assigning back to me until CI tests are passing |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 22 out of 22 changed files in this pull request and generated 7 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
billphipps
left a comment
billphipps
left a comment
There was a problem hiding this comment.
Looks great! Let me know when you want me to merge it!
Thank you!
…s, moved setting of TLS certificates into config and internal transport file
|
Force pushed to resolve merge conflict. |
3 participants
No description provided.