F-3805: length check in wh_Client_CertReadTrustedResponse#365
F-3805: length check in wh_Client_CertReadTrustedResponse#365padelsbach wants to merge 2 commits into
Conversation
bigbrett
left a comment
bigbrett
left a comment
There was a problem hiding this comment.
Yay for using new test harness
| const size_t whTestsServerCount = sizeof(whTestsServer) / sizeof(whTestsServer[0]); | ||
|
|
||
| const whTestCase whTestsClient[] = { | ||
| { "whTest_CertReadTrustedSmallBuffer", whTest_CertReadTrustedSmallBuffer }, |
There was a problem hiding this comment.
instead of being "flat" where each individual test is registered here, how do we feel about this just holding whTest_ClientCerts() which is the main driver for all client-side cert tests, then the new test you added could be a static function (as well as all the other cert tests that will be added) but they are all grouped together under one "functional" suite of tests.
For example, we already essentially do this with the crypto algo tests - just have one whTest_CryptoAes() and not whTest_CryptoAes128CheckBadArgsForKey() with nine million other permutations like that
There was a problem hiding this comment.
Good idea, makes for smaller diffs as tests are added. Coming right up...
2 participants
No description provided.