Fix SFTP_GetAttributes with fatfs for root#974
Open
J-Goldacker wants to merge 1 commit into
Open
Conversation
|
Can one of the admins verify this patch? |
Member
|
Hi @J-Goldacker , I don't see you on our approved contributor list. Can you tell us more about your project and use of wolfSSH? For such a small change we may treat this as a bug report. I've assigned this PR to @ejohnstown who is the project owner and can review and decide. Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After updating Filezilla to 3.70.5 (from 3.69.1) we got an error message during reception of the directory content. Connecting to a home directory not being root works. (This took us a while to find out.)
We tracked it down to SFTP_GetAttributes where f_stat is called for "/". f_stat doesn't support this and returns FR_INVALID_NAME. Interestingly, the code handling this is mainly there. But the function returns too early.