Fix SAKKE OOB write and correctness gap in sakke_hash_to_range#10442
Open
JeremiahM37 wants to merge 4 commits into
Open
Fix SAKKE OOB write and correctness gap in sakke_hash_to_range#10442JeremiahM37 wants to merge 4 commits into
JeremiahM37 wants to merge 4 commits into
Conversation
JeremiahM37
force-pushed
the
zd21783
branch
2 times, most recently
from
5388da1 to
1b22c51
Compare
|
JeremiahM37
force-pushed
the
zd21783
branch
4 times, most recently
from
1ede0c0 to
e8e1b98
Compare
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #10442
Scan targets checked: wolfcrypt-bugs, wolfcrypt-src
No new issues found in the changed files. ✅
JeremiahM37
force-pushed
the
zd21783
branch
3 times, most recently
from
7f24da5 to
d75fdcb
Compare
SparkiDev
requested changes
May 13, 2026
| if (i == hashSz) { | ||
| i = 0; | ||
| } | ||
| off = 0; |
| i = 0; | ||
| } | ||
| off = 0; | ||
| len = hashSz - skip; |
Contributor
There was a problem hiding this comment.
No need to assign to 'len' here - just put this into the xorbuf call.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
sakke_xor_in_vheap buffer overflow whenssvSz > hashSzand(ssvSz % hashSz) != 0.sakke_xor_in_vcorrectness gap — output for some(ssvSz, hashSz)combinations does not match RFC 6508 §5.1.wc_MakeSakkeEncapsulatedSSV/wc_DeriveSakkeSSVdid not validatessvSz.Fixes Audit 7 of zd21783
Testing
sakke_xor_in_v_oob_testandsakke_mask_correctness_testintests/unit.c.wolfcrypt/test/testwolfcryptSAKKE KAT still passes.