fix for tropic port AES key length used#10470
Open
JacobBarthelmeh wants to merge 2 commits into
Open
Conversation
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #10470
Scan targets checked: wolfcrypt-port-bugs
No new issues found in the changed files. ✅
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Fixes the TropicSquare Tropic01 crypto callback to use the actual AES key length (instead of a fixed block/max size) when retrieving keys and configuring the AES context.
Changes:
- Derive
keyLenfrom the active AES context for AES-GCM (enc/dec) and AES-CBC. - Pass
keyLenintoTropic01_GetKeyAES(...)to fetch the correct number of key bytes. - Pass
keyLenintowc_AesSetKey(...)instead ofWC_AES_BLOCK_SIZE.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
I think it's best if this is rebased onto #10449 once that simulator test is merged. Before this fix itself is merged. |
|
Contributor
Author
|
Retest this please Jenkins. Page not found. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fenrir report F-3333