fix Octeon AES-GCM J0 derivation when ivSz is a non-12-byte non-zero …#10471
Open
JacobBarthelmeh wants to merge 1 commit into
Open
fix Octeon AES-GCM J0 derivation when ivSz is a non-12-byte non-zero …#10471JacobBarthelmeh wants to merge 1 commit into
JacobBarthelmeh wants to merge 1 commit into
Conversation
…multiple of WC_AES_BLOCK_SIZE
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Fixes Octeon AES-GCM J0 derivation for non-12-byte IVs by avoiding an extra GHASH block when the IV length is an exact multiple of the AES block size (i.e., no remainder).
Changes:
- Skip the final zero-padded GHASH update when
remainder == 0during IV hashing. - Preserve correct GHASH processing for partial final IV blocks (
remainder > 0).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Contributor
Author
|
Retest this please Jenkins. No page found. |
Contributor
Author
|
Retest this please Jenkins. From what I can see it is : Which seems unrelated to these changes. |
Member
That is correct. Fixed in #10480 |
dgarske
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fenrir F-3336