Skip to content

Avoid unused variable errors in aesgcm_non12iv_test#10479

Open
padelsbach wants to merge 1 commit into
wolfSSL:masterfrom
padelsbach:aesgcm-unused-vars
Open

Avoid unused variable errors in aesgcm_non12iv_test#10479
padelsbach wants to merge 1 commit into
wolfSSL:masterfrom
padelsbach:aesgcm-unused-vars

Conversation

@padelsbach
Copy link
Copy Markdown
Contributor

@padelsbach padelsbach commented May 13, 2026

Description

Currently blocking wolfHSM CI with the error below:

cc  -std=c90 -Werror -Wall -Wextra -ffunction-sections -fdata-sections -ggdb -g3 -fsanitize=address -D_POSIX_C_SOURCE=200809L -DWOLFHSM_CFG -DWOLFSSL_USER_SETTINGS -DWOLFHSM_CFG_DEBUG -DWOLFHSM_CFG_DEBUG_VERBOSE -DWC_USE_DEVID=0x5748534D -DWOLFHSM_CFG_ENABLE_AUTHENTICATION -I. -I./config -I./../ -I../../../wolfssl -I../../../ -I../../..//port/posix -I../../..//examples/demo/client -c -o Build/wh_demo_client_wctest.o ../../..//examples/demo/client/wh_demo_client_wctest.c
../../../wolfssl/wolfcrypt/test/test.c: In function ‘aesgcm_non12iv_test’:
../../../wolfssl/wolfcrypt/test/test.c:19220:57: error: unused parameter ‘dec’ [-Werror=unused-parameter]
19220 | static wc_test_ret_t aesgcm_non12iv_test(Aes* enc, Aes* dec)
      |                                                    ~~~~~^~~
cc1: all warnings being treated as errors

Note: wolfHSM tests define BENCH_EMBEDDED which means BENCH_AESGCM_LARGE is undefined and dec is not used.

Testing

How did you test?

Checklist

  • added tests
  • updated/added doxygen
  • updated appropriate READMEs
  • Updated manual and documentation

@padelsbach padelsbach marked this pull request as ready for review May 13, 2026 17:50
Comment thread wolfcrypt/test/test.c Outdated
static wc_test_ret_t aesgcm_non12iv_test(Aes* enc, Aes* dec)
{
wc_test_ret_t ret = 0;
(void)enc;
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need to move this lower down... otherwise mixed declarations.. Not C89 compliant.

@padelsbach padelsbach force-pushed the aesgcm-unused-vars branch from 04470fa to 51540a0 Compare May 13, 2026 17:59
@padelsbach padelsbach requested a review from dgarske May 13, 2026 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants