Open
Conversation
…rough definition to make WC_ERR_TRACE() safe to use ungated in code.
…y defined in enum wc_HashType, and always either succeed if used properly, or return HASH_TYPE_E if gated out or used improperly; add detailed error code tracing in wolfcrypt/src/hash.c.
Contributor
Author
|
retest this please |
1 similar comment
Contributor
Author
|
retest this please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refactor
wc_Hash*so that knownwc_HashTypevalues are unconditionally defined inenum wc_HashType, and always either succeed if used properly, or returnHASH_TYPE_Eif gated out or used improperly; add detailed error code tracing inwolfcrypt/src/hash.c.wolfssl/wolfcrypt/error-crypt.h: add do-nothingWC_ERR_TRACE()fallthrough definition to makeWC_ERR_TRACE()safe to use ungated in code.tested with
wolfssl-multi-test.sh ... super-quick-check