ssl_sess: check fields in wolfSSL_d2i_SSL_SESSION.#9949
Open
philljj wants to merge 1 commit intowolfSSL:masterfrom
Open
ssl_sess: check fields in wolfSSL_d2i_SSL_SESSION.#9949philljj wants to merge 1 commit intowolfSSL:masterfrom
philljj wants to merge 1 commit intowolfSSL:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Improves robustness of session deserialization in wolfSSL_d2i_SSL_SESSION by validating length fields before copying into fixed-size buffers, preventing potential buffer overflows when parsing externally provided session blobs.
Changes:
- Add bounds check for
sessionIDSzagainstID_LENbefore copyingsessionID. - Add bounds check for
idLenagainstSERVER_ID_LENbefore copyingserverID. - Add bounds check for
sessionCtxSzagainstID_LENbefore copyingsessionCtx.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Check
idLenand similar fields in wolfSSL_d2i_SSL_SESSION.Fixes zd#21323.