Skip to content

20260311 Coverity changes #9956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rlm2002 wants to merge 4 commits into
base: master
Choose a base branch
from
+12 −3
Open

20260311 Coverity changes #9956

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8314aa5
catch MEMORY_E from CALLOC_ASNSETDATA()
rlm2002 Mar 10, 2026
d432759
verify algoSz is <= MAX_ALGO_SZ
rlm2002 Mar 10, 2026
6ebd967
bounds check on ext_dump
rlm2002 Mar 11, 2026
d359f42
set *inLen = outLen if output == NULL, if != NULL, check that outLen …
rlm2002 Mar 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion tests/quic.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -731,9 +731,13 @@ static void ext_dump(const byte *data, size_t data_len, int indent)
word16 len16, etype, i;

printf("%*sextensions:\n", indent, " ");
while (idx < data_len) {
while (idx + 4 <= data_len) {
ato16(&data[idx], &etype); /* extension type */
ato16(&data[idx+2], &len16); /* extension length */
if (idx + 4 + len16 > data_len) {
printf(" unexpected extension length\n");
break;
}
printf(" extension: %04x [", etype);
for (i = 0; i < len16; ++i) {
printf("%s0x%02x", (i? ", ": ""), data[idx+4+i]);
Expand Down
9 changes: 7 additions & 2 deletions wolfcrypt/src/asn.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12912,15 +12912,16 @@ static int DsaKeyIntsToDer(DsaKey* key, byte* output, word32* inLen,
seqSz = SetSequence(verSz + intTotalLen, seq);

outLen = seqSz + verSz + intTotalLen;
*inLen = outLen;
if (output == NULL) {
*inLen = outLen;
FreeTmpDsas(tmps, key->heap, ints);
return WC_NO_ERR_TRACE(LENGTH_ONLY_E);
}
if (outLen > *inLen) {
FreeTmpDsas(tmps, key->heap, ints);
return BAD_FUNC_ARG;
}
*inLen = outLen;

/* write to output */
XMEMCPY(output, seq, seqSz);
Expand Down Expand Up @@ -17964,6 +17965,10 @@ static word32 SetAlgoIDImpl(int algoOID, byte* output, int type, int curveSz,
word32 algoSz = 0;

CALLOC_ASNSETDATA(dataASN, algoIdASN_Length, ret, NULL);
if(ret < 0) {
/* Catch MEMORY_E */
return 0;
}

algoName = OidFromId((word32)algoOID, (word32)type, &algoSz);
if (algoName == NULL) {
Expand Down Expand Up @@ -42549,7 +42554,7 @@ int wc_MakeCRL_ex(const byte* issuerDer, word32 issuerSz,

/* Signature AlgorithmIdentifier */
algoSz = SetAlgoID(sigType, algoBuf, oidSigType, 0);
if (algoSz == 0)
if (algoSz == 0 || algoSz > MAX_ALGO_SZ)
return ALGO_ID_E;

/* thisUpdate */
Expand Down
Loading