Open
Conversation
GutenbergView previously extended WebView directly and delegated all loading UI (progress bar, spinner, error states) to consumers via the EditorLoadingListener interface. This forced every app embedding the editor to implement its own loading UI boilerplate. This change makes GutenbergView extend FrameLayout instead, containing an internal WebView plus overlay views for loading states: - EditorProgressView (progress bar + label) during dependency fetching - ProgressBar (circular/indeterminate) during WebView initialization - EditorErrorView (new) for error states The view manages its own state transitions with 200ms fade animations, matching the iOS EditorViewController pattern. The EditorLoadingListener interface is removed entirely — consumers no longer need loading UI code. Changes: - GutenbergView: WebView -> FrameLayout with internal WebView child - New EditorErrorView for displaying load failures - Delete EditorLoadingListener (no longer needed) - Simplify demo EditorActivity by removing ~90 lines of loading UI - Update tests to use editorWebView accessor for WebView properties - Delete unused activity_editor.xml layout Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Cancel in-flight view animations in onDetachedFromWindow Prevents withEndAction callbacks from firing on detached views if the editor is closed mid-animation. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Remove unused LoadingState enum from GutenbergView Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Remove unused ASSET_LOADING_TIMEOUT_MS constant from GutenbergView Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…edFromWindow These two listeners were not being nulled out during teardown, inconsistent with all other listener cleanup in the same method. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
dcalhoun
approved these changes
Feb 19, 2026
Member
dcalhoun
left a comment
dcalhoun
left a comment
There was a problem hiding this comment.
Tested well for me. I left a few suggestions, but non are blocking. Rebasing this atop the latest trunk branch should resolve the CI failures.
Comment on lines
+211
to
+214
| // Initialize the asset loader now that context is available | ||
| assetLoader = WebViewAssetLoader.Builder() | ||
| .addPathHandler("/assets/", AssetsPathHandler(context)) | ||
| .build() |
Member
There was a problem hiding this comment.
This seems duplicative of assetLoader initialization on lines 91-93. Should we remove one?
| this.dependencies = dependencies | ||
|
|
||
| // FAST PATH: Dependencies were provided - load immediately | ||
| showSpinnerPhase() |
Member
There was a problem hiding this comment.
This may be duplicative since showSpinnerPhase() is invoked within loadEditor(). Remove it?
| } | ||
| gravity = Gravity.CENTER | ||
| TextViewCompat.setTextAppearance(this, android.R.style.TextAppearance_Material_Subhead) | ||
| text = "Failed to load editor" |
Member
There was a problem hiding this comment.
For a future PR, we should likely localize strings like this in a manner similar to iOS.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Moves the editor loading UI from #316 into its own PR
Why?
The smaller change is easier to validate.
How?
Adds loading UI – if you test with the sample app, you'll see that it was removed from the activity and added to the view.