Merged
Conversation
Contributor
|
| App Name | Jetpack | |
| Configuration | Release-Alpha | |
| Build Number | 31039 | |
| Version | PR #25272 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | 694efac | |
| Installation URL | 3plsdnte7o2tg |
Contributor
|
| App Name | WordPress | |
| Configuration | Release-Alpha | |
| Build Number | 31039 | |
| Version | PR #25272 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | 694efac | |
| Installation URL | 2vke1umln5aa0 |
Contributor
🤖 Build Failure AnalysisThis build has failures. Claude has analyzed them - check the build annotations for details. |
kean
force-pushed
the
task/remove-keychain-dependency-from-wpaccount
branch
from
1a46d04 to
2502056
Compare
kean
commented
Feb 19, 2026
| /// It's reserved for Objective-C to Swift interoperability in the context of separating this model from the app target and will be removed at some point. | ||
| @property (nonatomic, strong, nullable) WordPressComRestApi *_private_wordPressComRestApi; | ||
|
|
||
| @property (nonatomic, copy, nullable) NSString *cachedToken; |
Contributor
Author
There was a problem hiding this comment.
I plan to remove it in the future PR, so it won't be in the public API.
It seems incorrect to cache token on the per-instance basic. The the app cleans the token (account.authToken = nil), in invalidates cachedToken only on this instance. The other instances might continue to return the same invalidated cached token.
In the future PRs, I plan to introduce a shared keychain service that would contain an in-memory dictionary for cached token. It will also allow us to uncomment some of the tests.
crazytonyli
approved these changes
Feb 19, 2026
Base automatically changed from
task/update-blog-tests-to-swift-testing
to
trunk
February 20, 2026 01:17
kean
force-pushed
the
task/remove-keychain-dependency-from-wpaccount
branch
from
2502056 to
5cf03b0
Compare
kean
force-pushed
the
task/remove-keychain-dependency-from-wpaccount
branch
from
5cf03b0 to
694efac
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a first part of the rework of
WPAccountauth token management to Swift. It is more of a mechanical change that doesn't introduce any refactoring.