Convert URL-related parts of Blog.m to Swift#25276
Merged
Conversation
Collaborator
Generated by 🚫 Danger |
kean
commented
Feb 20, 2026
| } | ||
| } | ||
|
|
||
| // Used as a key to store passwords, if you change the algorithm, logins will break |
Contributor
Author
There was a problem hiding this comment.
This comment seems obsolete. I found where the app uses self.xmlrpc, but nothing else.
| /// Builds an admin URL by appending the given path to the admin base URL. | ||
| public func makeAdminURL(path: String) -> URL? { | ||
| var base = getOptionString(name: "admin_url") ?? url(withPath: "wp-admin/") ?? "" | ||
| if !base.hasSuffix("/") { |
Contributor
Author
There was a problem hiding this comment.
There may be a better way to implement some of these, but I decided to keep direct ObjC to Swift conversion for now to reduce risk of breaking something.
|
|
||
| if blog.isAtomic { | ||
| authenticationType = blog.isPrivate() ? .privateAtomic(blogID: dotComID) : .atomic(loginURL: blog.loginUrl()) | ||
| authenticationType = blog.isPrivate() ? .privateAtomic(blogID: dotComID) : .atomic(loginURL: blog.loginURL?.absoluteString ?? "") |
Contributor
Author
There was a problem hiding this comment.
I kept the existing login in tact and manually tested it:
Screen.Recording.2026-02-20.at.9.15.55.AM.mov
kean
force-pushed
the
task/blog-swift-rewrite
branch
from
0ee925b to
3d2ee7a
Compare
|
Contributor
|
| App Name | WordPress | |
| Configuration | Release-Alpha | |
| Build Number | 31023 | |
| Version | PR #25276 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | 3d2ee7a | |
| Installation URL | 6cm7gsqhr79eo |
Contributor
|
| App Name | Jetpack | |
| Configuration | Release-Alpha | |
| Build Number | 31023 | |
| Version | PR #25276 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | 3d2ee7a | |
| Installation URL | 0u1hm8733kg58 |
Contributor
🤖 Build Failure AnalysisThis build has failures. Claude has analyzed them - check the build annotations for details. |
jkmassel
reviewed
Feb 20, 2026
|
|
||
| /// User-facing display URL with protocol and trailing slash stripped, IDN decoded. | ||
| @objc public var displayURL: String? { | ||
| guard let url else { return nil } |
Contributor
There was a problem hiding this comment.
I can't imagine a situation where the site URL should be nil?
But I guess that's another PR
jkmassel
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR affects
displayURL,loginURL, etc. In addition to a mechanical rewrite I changed some of these to be more idiomatic Swift: naming,URL?, etc.