Conversation
Generated by 🚫 Danger |
| .build() | ||
|
|
||
| #expect(blog.supports(.pluginManagement)) | ||
| #expect(!blog.supports(.pluginManagement)) |
There was a problem hiding this comment.
Turns out, the original expectation was incorrect.
This was a failing test with a wrong expectation.
RCA:
This code was doing nothing because the settings object was not initialized at this point.
.with(siteVisibility: .private)
| return timeZone | ||
| } | ||
| } | ||
| return .gmt |
There was a problem hiding this comment.
It's not great that var timeZone: TimeZone? is defined as optional but always returns non-optional .gmt timezone. It is the original behavior, so I preserved it. If we don't know the blog timezone, it should probably just return nil.
| } | ||
|
|
||
| /// - warning: DO NOT USE. This doesn't work for negative values, e.g. "-11" | ||
| /// and potentially other scenarios. |
There was a problem hiding this comment.
There are only three places where it's used, so I added a note to remove it.
kean
force-pushed
the
task/blog-swift-rewrite-p2
branch
from
b7acefe to
6864c27
Compare
|
| App Name | WordPress | |
| Configuration | Release-Alpha | |
| Build Number | 31033 | |
| Version | PR #25277 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | 38a3719 | |
| Installation URL | 02m9jpo4eu4d0 |
|
| App Name | Jetpack | |
| Configuration | Release-Alpha | |
| Build Number | 31033 | |
| Version | PR #25277 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | 38a3719 | |
| Installation URL | 18eg4gga34730 |
| #expect(blog.timeZone == TimeZone(secondsFromGMT: -5 * 3600)) | ||
| } | ||
|
|
||
| @Test func timeZoneUsesXMLRPCTimeZoneOption() { |
There was a problem hiding this comment.
I compared these tests with the ones from https://github.com/Automattic/wordpress-rs/blob/trunk/wp_serde_helper/src/offset.rs – might be worth doing a fractional offset like -5.5 as well for completeness sake.
There was a problem hiding this comment.
Oh – also this can be a string value as well.
There was a problem hiding this comment.
I added a couple of fractional offset tests: 3b4bad6. Looks like the options parsing and the rest works OK.
🤖 Build Failure AnalysisThis build has failures. Claude has analyzed them - check the build annotations for details. |
jkmassel
left a comment
jkmassel
left a comment
There was a problem hiding this comment.
Couple of issues around offset parsing, but then this is good to go.
kean
force-pushed
the
task/blog-swift-rewrite-p2
branch
from
3b4bad6 to
38a3719
Compare
|
4 participants
n/a