Skip to content

fix(doctor): point COOKIE_DOMAIN_NOT_SET at a real docs URL #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sheldon-workos wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −1
Open

fix(doctor): point COOKIE_DOMAIN_NOT_SET at a real docs URL #159

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/doctor/issues.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ export const ISSUE_DEFINITIONS = {
severity: 'warning' as const,
message: 'Cookie domain not explicitly set',
remediation: 'Consider setting WORKOS_COOKIE_DOMAIN for cross-subdomain auth',
docsUrl: 'https://workos.com/docs/authkit/cookie-domain',
docsUrl: 'https://github.com/workos/authkit-nextjs#optional-configuration',
Copy link
Copy Markdown

@greptile-apps greptile-apps Bot May 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 URL is Next.js-specific but warning fires for all AuthKit SDKs

The new docsUrl points to the authkit-nextjs README, but COOKIE_DOMAIN_NOT_SET is emitted whenever report.sdk.isAuthKit is true (line 102), which covers non-Next.js AuthKit integrations (Remix, SvelteKit, etc.). Those users will be sent to Next.js-specific instructions that may not directly apply to their setup. A first-party docs page or a more generic reference would cover the full audience, though this is still a clear improvement over a 404.

Copy link
Copy Markdown

@gjtorikian gjtorikian May 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tending to agree with Greptile here. Considering that https://github.com/workos/authkit-tanstack-start et al also use these env vars what do you think about opening a docs PR for this? 😓

},
NO_SDK_FOUND: {
severity: 'error' as const,
Expand Down
Loading