Skip to content

fix(renovate): explicitly enable minor and patch updates#102

Merged
gjtorikian merged 2 commits into
mainfrom
fix/renovate-enable-minor-patch
May 27, 2026
Merged

fix(renovate): explicitly enable minor and patch updates#102
gjtorikian merged 2 commits into
mainfrom
fix/renovate-enable-minor-patch

Conversation

@willporter-workos
Copy link
Copy Markdown
Contributor

Summary

The shared workos/renovate-config preset now explicitly disables major and minor updates for non-github-actions managers to enforce a patch-only policy on the monorepo.

Renovate applies packageRules in order — preset rules first, then repo rules on top. Because the shared preset sets enabled: false for minor updates, and this repo's rule sets automerge: true but not enabled: true, minor updates would silently stop getting PRs.

Fix

Add "enabled": true to the existing minor/patch rule so it explicitly re-enables minor updates after the shared preset disables them.

🤖 Generated with Claude Code

The shared preset now disables minor updates by default. Add enabled: true
to the minor/patch rule so this repo continues to receive minor PRs.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@willporter-workos willporter-workos requested a review from a team as a code owner May 26, 2026 20:00
@greptile-apps
Copy link
Copy Markdown

greptile-apps Bot commented May 26, 2026

Greptile Summary

This PR refactors renovate.json from a locally-defined configuration to a thin wrapper that delegates entirely to the workos/renovate-config:public shared preset. The stated motivation is to re-enable minor updates that the shared preset now silently disables.

  • All local config removed: The schedule (on the 15th day of the month before 12pm), timezone, rebaseWhen, and all five packageRules entries (minor/patch automerge, major no-automerge, digest handling, github-actions grouping) have been deleted from this file.
  • Preset reference changed: The extends entry moves from github>workos/renovate-config (default preset) to github>workos/renovate-config:public (a named preset), meaning the correctness of this change is entirely contingent on the contents of that external preset.

Confidence Score: 3/5

The change removes all local Renovate scheduling and package rules, delegating everything to an external shared preset whose contents cannot be verified in this diff.

The entire local configuration — monthly schedule, automerge rules for minor/patch, github-actions grouping, and rebase policy — has been stripped and replaced with a single external preset reference. Without access to workos/renovate-config:public, it is impossible to confirm that none of these behaviours regress. The PR description also describes a different fix than what was actually implemented, adding uncertainty about intent.

renovate.json — the shared preset workos/renovate-config:public should be audited to confirm it carries forward the schedule, timezone, rebaseWhen, and all removed packageRules.

Important Files Changed

Filename Overview
renovate.json Replaces all local Renovate config (schedule, timezone, rebaseWhen, packageRules) with a single shared preset reference github>workos/renovate-config:public; correctness depends entirely on what that preset contains.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Renovate Bot] --> B[renovate.json]
    B --> C["extends: github>workos/renovate-config:public"]
    C --> D{Shared Preset\nworkos/renovate-config:public}
    D --> E[Schedule?]
    D --> F[packageRules: minor/patch automerge?]
    D --> G[packageRules: github-actions grouping?]
    D --> H[timezone / rebaseWhen?]
    E -->|If missing| I[⚠️ Runs on default daily cadence]
    F -->|If missing| J[⚠️ No automerge for minor/patch]
    G -->|If missing| K[⚠️ No grouping for github-actions]
Loading

Reviews (2): Last reviewed commit: "Update Renovate configuration to public ..." | Re-trigger Greptile

@gjtorikian gjtorikian merged commit d781f4e into main May 27, 2026
5 checks passed
@gjtorikian gjtorikian deleted the fix/renovate-enable-minor-patch branch May 27, 2026 20:25
Comment thread renovate.json
"groupSlug": "github-actions-major",
"automerge": false
}
"github>workos/renovate-config:public"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 PR description does not match the actual change

The PR description says "Add enabled: true to the existing minor/patch rule," but the diff completely removes all local packageRules, schedule, timezone, and rebaseWhen config and switches the preset reference from github>workos/renovate-config to github>workos/renovate-config:public. This is a much larger change than described. If workos/renovate-config:public does not replicate the removed schedule ("on the 15th day of the month before 12pm"), timezone, and package rules (automerge for minor/patch, no automerge for major/digest, github-actions grouping), those behaviours will silently regress — for example, Renovate may start running on its default daily cadence instead of the monthly schedule. Can you confirm that workos/renovate-config:public includes equivalent schedule, timezone, rebaseWhen, and packageRules (automerge for minor/patch, github-actions grouping, etc.) so none of the removed local config is lost?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants