-
Notifications
You must be signed in to change notification settings - Fork 25
Bump version to v5.38.0 #509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Releases #507 to add support for WorkOS Pipes
Greptile OverviewGreptile SummaryThis PR bumps the package version from 5.37.0 to 5.38.0, preparing for a minor release that includes:
Version Bump AnalysisThe version increment follows semantic versioning correctly:
Technical ImplementationThe version is defined in
Verification✅ Version format is valid (X.Y.Z semantic versioning) Note on PR DescriptionThe PR description mentions only #507 (Pipes support) but the release includes additional features from #506 and #504. While the version bump itself is correct, the description could be more comprehensive to reflect all changes being released. Confidence Score: 5/5
Important Files ChangedFile Analysis
Sequence DiagramsequenceDiagram
participant Dev as Developer
participant PR as PR #509
participant Version as __about__.py
participant Setup as setup.py
participant CI as GitHub Actions
participant PyPI as Python Package Index
Dev->>PR: Create version bump PR
PR->>Version: Update __version__ = "5.38.0"
Note over Version: Increments from 5.37.0<br/>to 5.38.0 (minor version)
Dev->>PR: Merge to main
PR->>CI: Trigger release workflow
CI->>Setup: Read version
Setup->>Version: Import __version__
Version-->>Setup: Return "5.38.0"
Setup-->>CI: Return version metadata
CI->>CI: Run tests
CI->>CI: Build sdist & wheel
CI->>PyPI: Upload v5.38.0 package
Note over PyPI: workos-python v5.38.0<br/>now available with:<br/>- Pipes support (#507)<br/>- Vault API method (#506)<br/>- Other improvements
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 file reviewed, 1 comment
| __package_url__ = "https://github.com/workos-inc/workos-python" | ||
|
|
||
| __version__ = "5.37.0" | ||
| __version__ = "5.38.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR description states this "Releases #507 to add support for WorkOS Pipes", but v5.38.0 actually includes three feature additions merged since v5.37.0:
- Add Python SDK support for WorkOS Pipes #507 - WorkOS Pipes support (mentioned in description)
- Add
read_object_by_namemethod for Vault API #506 - New Vault APIread_object_by_namemethod (not mentioned) - Add context7.json to repo #504 - context7.json addition (not mentioned)
Consider updating the PR description to accurately reflect all changes being released, especially #506 which adds a new public API method. This helps users understand the full scope of the release when reviewing release notes or changelogs.
The version bump itself is correct - incrementing the minor version (5.37.0 → 5.38.0) is appropriate for these backward-compatible feature additions per semantic versioning.
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Prompt To Fix With AI
This is a comment left during a code review.
Path: workos/__about__.py
Line: 15:15
Comment:
The PR description states this "Releases #507 to add support for WorkOS Pipes", but v5.38.0 actually includes three feature additions merged since v5.37.0:
1. **#507** - WorkOS Pipes support (mentioned in description)
2. **#506** - New Vault API `read_object_by_name` method (not mentioned)
3. **#504** - context7.json addition (not mentioned)
Consider updating the PR description to accurately reflect all changes being released, especially #506 which adds a new public API method. This helps users understand the full scope of the release when reviewing release notes or changelogs.
The version bump itself is correct - incrementing the minor version (5.37.0 → 5.38.0) is appropriate for these backward-compatible feature additions per semantic versioning.
<sub>Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!</sub>
How can I resolve this? If you propose a fix, please make it concise.
Description
Releases #507 to add support for WorkOS Pipes
Documentation
Does this require changes to the WorkOS Docs? E.g. the API Reference or code snippets need updates.
If yes, link a related docs PR and add a docs maintainer as a reviewer. Their approval is required.