Skip to content

Tests: Further improve Windows compatibility #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
swissspidy merged 5 commits into from
Apr 2, 2026
Merged

Tests: Further improve Windows compatibility #327

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
45528b5
Adjust quotes
swissspidy Mar 29, 2026
fd9ea85
escape
swissspidy Mar 29, 2026
0dce7a4
Use eval-file
swissspidy Apr 1, 2026
090f106
Update features/core.feature
swissspidy Apr 1, 2026
55280a2
Skip some more tests on Windows
swissspidy Apr 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions features/core-download.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -386,6 +386,10 @@ Feature: Download WordPress
"""
And the return code should be 1

@skip-windows
Scenario: Fail if path can't be created (root-level-directory)
Given an empty directory
Copy link

Copilot AI Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This new scenario is environment-dependent: creating /root-level-directory will succeed when tests run with elevated privileges (or in some container setups), and it can also behave differently if the directory already exists from a previous run. That makes the test potentially flaky on CI and locally. Consider making the failure deterministic by ensuring the directory is removed before the scenario (using the existing “non-existent … directory” step) and/or by targeting a consistently non-writable location or a non-writable directory created within the test workspace.

Suggested change
Given an empty directory
Given an empty directory
And a non-existent '/root-level-directory' directory

Copilot uses AI. Check for mistakes.

When I try `wp core download --path=/root-level-directory`
Then STDERR should contain:
"""
Expand Down
8 changes: 7 additions & 1 deletion features/core.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,12 @@ Feature: Manage WordPress installation
"""
And the return code should be 0

When I run `wp eval 'echo $GLOBALS["current_site"]->domain;'`
Given a current-site-domain.php file:
"""
<?php
echo $GLOBALS['current_site']->domain;
"""
When I run `wp eval-file current-site-domain.php`
Then STDOUT should be:
"""
foobar.org
Expand Down Expand Up @@ -296,6 +301,7 @@ Feature: Manage WordPress installation
http://localhost:8001
"""

@skip-windows
Scenario: Test output in a multisite install with custom base path
Given a WP install

Expand Down
Loading