-
Notifications
You must be signed in to change notification settings - Fork 85
Add warning in wp plugin is-active for missing plugin files still in active_plugins
#480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Copilot
wants to merge
11
commits into
main
Choose a base branch
from
copilot/fix-active-plugins-check
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+139
−0
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
5ec2278
Initial plan
Copilot 9649a81
Add warning when plugin is in active_plugins but file doesn't exist
Copilot b0c8d9d
Add documentation for is-active warning behavior
Copilot b892b03
Fix type inconsistency in is_active method
Copilot 81943ba
Add detailed comments explaining active_plugins structure
Copilot 76ee8dc
Fix test: activate plugin before deactivating in test scenario
Copilot b99a9be
Update src/Plugin_Command.php
swissspidy 920cefb
Update src/Plugin_Command.php
swissspidy d1ccde9
Update src/Plugin_Command.php
swissspidy 4f2f884
Add test for network-activated plugins with missing files
Copilot 729a94c
Merge branch 'main' into copilot/fix-active-plugins-check
swissspidy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,86 @@ | ||
| Feature: Check if a WordPress plugin is active | ||
|
|
||
| Background: | ||
| Given a WP install | ||
|
|
||
| Scenario: Check if an active plugin is active | ||
| When I run `wp plugin activate akismet` | ||
| Then STDOUT should contain: | ||
| """ | ||
| Success: | ||
| """ | ||
|
|
||
| When I run `wp plugin is-active akismet` | ||
| Then the return code should be 0 | ||
|
|
||
| Scenario: Check if an inactive plugin is not active | ||
| When I run `wp plugin activate akismet` | ||
| Then STDOUT should contain: | ||
| """ | ||
| Success: | ||
| """ | ||
|
|
||
| When I run `wp plugin deactivate akismet` | ||
| Then STDOUT should contain: | ||
| """ | ||
| Success: | ||
| """ | ||
|
|
||
| When I try `wp plugin is-active akismet` | ||
| Then the return code should be 1 | ||
|
|
||
| Scenario: Check if a non-existent plugin is not active | ||
| When I try `wp plugin is-active non-existent-plugin` | ||
| Then the return code should be 1 | ||
|
|
||
| Scenario: Warn when plugin is in active_plugins but file does not exist | ||
| When I run `wp plugin activate akismet` | ||
| Then STDOUT should contain: | ||
| """ | ||
| Success: | ||
| """ | ||
|
|
||
| When I run `wp plugin is-active akismet` | ||
| Then the return code should be 0 | ||
|
|
||
| # Remove the plugin directory | ||
| When I run `wp plugin path akismet --dir` | ||
| Then save STDOUT as {PLUGIN_PATH} | ||
|
|
||
| When I run `rm -rf {PLUGIN_PATH}` | ||
| Then the return code should be 0 | ||
|
|
||
| # Now the plugin file is gone but still in active_plugins | ||
| When I try `wp plugin is-active akismet` | ||
| Then STDERR should contain: | ||
| """ | ||
| Warning: Plugin 'akismet' is marked as active but the plugin file does not exist. | ||
| """ | ||
| And the return code should be 1 | ||
|
|
||
| Scenario: Warn when network-activated plugin is in active_sitewide_plugins but file does not exist | ||
| Given a WP multisite install | ||
|
|
||
| When I run `wp plugin activate akismet --network` | ||
| Then STDOUT should contain: | ||
| """ | ||
| Success: | ||
| """ | ||
|
|
||
| When I run `wp plugin is-active akismet --network` | ||
| Then the return code should be 0 | ||
|
|
||
| # Remove the plugin directory | ||
| When I run `wp plugin path akismet --dir` | ||
| Then save STDOUT as {PLUGIN_PATH} | ||
|
|
||
| When I run `rm -rf {PLUGIN_PATH}` | ||
| Then the return code should be 0 | ||
|
|
||
| # Now the plugin file is gone but still in active_sitewide_plugins | ||
| When I try `wp plugin is-active akismet --network` | ||
| Then STDERR should contain: | ||
| """ | ||
| Warning: Plugin 'akismet' is marked as active but the plugin file does not exist. | ||
| """ | ||
| And the return code should be 1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These
! empty( $input_name )checks appear to be redundant. The<plugin>argument is required for this command, so$input_name(from$args[0]) should always be a non-empty string. Removing these checks will simplify the condition.On a related note, this logic for finding a plugin by name is duplicated from
WP_CLI\Fetchers\Plugin::get(). For future refactoring, it would be beneficial to extract this into a shared helper to improve maintainability.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot address #480 (comment)