Skip to content

Tests: Improve Windows compatibility#232

Merged
swissspidy merged 14 commits intomainfrom
fix/windows-tests
Apr 10, 2026
Merged

Tests: Improve Windows compatibility#232
swissspidy merged 14 commits intomainfrom
fix/windows-tests

Conversation

@swissspidy
Copy link
Copy Markdown
Member

No description provided.

@swissspidy swissspidy added this to the 2.7.1 milestone Mar 28, 2026
@github-actions
Copy link
Copy Markdown
Contributor

Hello! 👋

Thanks for opening this pull request! Please check out our contributing guidelines. We appreciate you taking the initiative to contribute to this project.

Contributing isn't limited to just code. We encourage you to contribute in the way that best fits your abilities, by writing tutorials, giving a demo at your local meetup, helping other users with their support questions, or revising our documentation.

Here are some useful Composer commands to get you started:

  • composer install: Install dependencies.
  • composer test: Run the full test suite.
  • composer phpcs: Check for code style violations.
  • composer phpcbf: Automatically fix code style violations.
  • composer phpunit: Run unit tests.
  • composer behat: Run behavior-driven tests.

To run a single Behat test, you can use the following command:

# Run all tests in a single file
composer behat features/some-feature.feature

# Run only a specific scenario (where 123 is the line number of the "Scenario:" title)
composer behat features/some-feature.feature:123

You can find a list of all available Behat steps in our handbook.

@github-actions github-actions bot added help-wanted Extra attention is needed scope:testing Related to testing labels Mar 28, 2026
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request replaces the wget command with curl in the package installation feature tests to improve cross-platform compatibility. A review comment suggests updating the GitHub archive URL to reference the main branch instead of master to align with the repository's current default branch naming.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 28, 2026

Codecov Report

❌ Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/Package_Command.php 66.66% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@swissspidy swissspidy marked this pull request as ready for review March 28, 2026 22:35
@swissspidy swissspidy requested a review from a team as a code owner March 28, 2026 22:35
Copilot AI review requested due to automatic review settings March 28, 2026 22:35
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the package installation Behat feature to use a Windows-friendly download command for fetching a ZIP fixture from GitHub.

Changes:

  • Replaces wget with curl for downloading the ZIP in the “local zip” install scenario.
  • Switches the GitHub archive URL from master.zip to main.zip for that download.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@swissspidy swissspidy removed the help-wanted Extra attention is needed label Mar 29, 2026
@swissspidy swissspidy merged commit 01b9fa3 into main Apr 10, 2026
73 checks passed
@swissspidy swissspidy deleted the fix/windows-tests branch April 10, 2026 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope:testing Related to testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants