Skip to content

Conversation

@colinmurphy
Copy link
Member

@colinmurphy colinmurphy commented May 30, 2025

Description

Important

The PR #236 should be reviewed and merged first.

This fixes #226 and removes "unique post slug functionality" which as a tean we agreed to remove.

Related Issue

#226

Dependant PRs

#236

Type of Change

  • ✅ Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactoring (no functional changes)
  • 📄 Example update (no functional changes)
  • 📝 Documentation update
  • 🔍 Performance improvement
  • 🧪 Test update

How Has This Been Tested?

Screenshots

Checklist

  • I have read the CONTRIBUTING document
  • My code follows the project's coding standards
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • Any dependent changes have been highlighted, merged or published

@github-actions
Copy link

ℹ️ Download the hwp-previews plugin artifact from this workflow run (see the 'Artifacts' section at the bottom).

@colinmurphy colinmurphy marked this pull request as ready for review May 30, 2025 18:35
@colinmurphy colinmurphy requested a review from a team as a code owner May 30, 2025 18:36
@github-actions
Copy link

ℹ️ Download the hwp-previews plugin artifact from this workflow run (see the 'Artifacts' section at the bottom).

@colinmurphy colinmurphy changed the title chore: DRAFT remove uri functionality chore: remove uri functionality May 30, 2025
@colinmurphy colinmurphy changed the title chore: remove uri functionality chore: remove unique post slug functionality May 30, 2025
ahuseyn
ahuseyn previously approved these changes Jun 3, 2025
@colinmurphy colinmurphy enabled auto-merge June 3, 2025 11:01
@colinmurphy colinmurphy dismissed ahuseyn’s stale review June 3, 2025 11:01

The merge-base changed after approval.

@ahuseyn ahuseyn self-requested a review June 3, 2025 16:23
ahuseyn
ahuseyn previously approved these changes Jun 3, 2025
@colinmurphy colinmurphy dismissed ahuseyn’s stale review June 3, 2025 16:23

The merge-base changed after approval.

@colinmurphy colinmurphy disabled auto-merge June 3, 2025 16:24
@colinmurphy colinmurphy requested a review from ahuseyn June 3, 2025 16:24
ahuseyn
ahuseyn previously approved these changes Jun 3, 2025
@colinmurphy colinmurphy dismissed ahuseyn’s stale review June 3, 2025 16:28

The merge-base changed after approval.

@ahuseyn ahuseyn self-requested a review June 3, 2025 16:45
ahuseyn
ahuseyn previously approved these changes Jun 3, 2025
@colinmurphy colinmurphy dismissed ahuseyn’s stale review June 3, 2025 16:46

The merge-base changed after approval.

@colinmurphy colinmurphy requested a review from ahuseyn June 3, 2025 16:47
@github-actions
Copy link

github-actions bot commented Jun 3, 2025

ℹ️ Download the hwp-previews plugin artifact from this workflow run (see the 'Artifacts' section at the bottom).

@colinmurphy colinmurphy enabled auto-merge June 3, 2025 17:44
Copy link
Member

@josephfusco josephfusco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@colinmurphy colinmurphy added this pull request to the merge queue Jun 3, 2025
Merged via the queue into main with commit a7e84a9 Jun 3, 2025
3 checks passed
@colinmurphy colinmurphy deleted the chore-remove-uri-functionality branch June 3, 2025 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore: Previews - use database ID instead of URI

4 participants