Skip to content

Fix crash on immediate vertex batches larger than staging buffer #827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
FurryMileon wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Fix crash on immediate vertex batches larger than staging buffer #827

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/main/java/net/vulkanmod/render/engine/VkCommandEncoder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,6 +290,14 @@ public void writeToBuffer(GpuBufferSlice gpuBufferSlice, ByteBuffer byteBuffer)
var commandBuffer = Renderer.getInstance().getTransferCb();

StagingBuffer stagingBuffer = Vulkan.getStagingBuffer();

// Large immediate batches (e.g. many entities sharing one RenderType) can
// exceed the default staging buffer; fall back to a one-shot oversized buffer.
if (size > stagingBuffer.getBufferSize()) {
stagingBuffer = new StagingBuffer(size);
stagingBuffer.scheduleFree();
}

stagingBuffer.copyBuffer(size, byteBuffer);

long srcOffset = stagingBuffer.getOffset();
Expand Down