geotiff: mark int-coord round-trip hotfix tests as integration-only#1976
Merged
Conversation
The two test_int_coords_round_trip_hotfix_1962 tests delete a tempfile after open_geotiff returns. On Windows, the read path keeps a handle open through the returned DataArray, so os.remove raises WinError 32 and the macOS/Windows CI matrix turns red. Mark them with a new requires_integration marker (XRSPATIAL_RUN_INTEGRATION=1 to opt in) so they skip by default and stay available for local runs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_int_coords_round_trip_hotfix_1962tests delete a tempfile afteropen_geotiffreturns. On Windows the read path holds a handle through the returned DataArray, soos.removeraisesWinError 32and the Windows/macOS jobs go red (seen on geotiff: cross-library accuracy test (rasterio vs xrspatial vs zarr) (#1961) #1963).requires_integrationmarker inxrspatial/geotiff/tests/conftest.py(gated onXRSPATIAL_RUN_INTEGRATION=1) and applies it to the two tests so CI skips them by default while local runs still cover them.Test plan
pytest xrspatial/geotiff/tests/test_int_coords_round_trip_hotfix_1962.py-> both skippedXRSPATIAL_RUN_INTEGRATION=1 pytest xrspatial/geotiff/tests/test_int_coords_round_trip_hotfix_1962.py-> both passed