Test all supported LLVM versions at once#58
Merged
xd009642 merged 1 commit intoxd009642:masterfrom Sep 28, 2025
Merged
Conversation
jyn514
force-pushed
the
tests
branch
4 times, most recently
from
8bb14d2 to
f965655
Compare
jyn514
commented
Sep 27, 2025
xd009642
reviewed
Sep 27, 2025
jyn514
force-pushed
the
tests
branch
2 times, most recently
from
7a6e56c to
8666751
Compare
jyn514
force-pushed
the
tests
branch
2 times, most recently
from
a85c43e to
ab6c948
Compare
Contributor
Author
|
Updated this to pull in your fix for the LLVM 16 thing on main, this should be ready for review again :) |
Owner
|
Cool, I'll try and give it a look today - though I merged in the other one as it's smaller so conflicts need sorting 😅 |
xd009642
reviewed
Sep 28, 2025
Owner
xd009642
left a comment
xd009642
left a comment
There was a problem hiding this comment.
Just one question mainly, otherwise looks good.
Previously, testing all supported configurations required installing many different versions of rustc manually. Now, it only requires running `cargo test --all-features`. This introduces a dependency on `rustup`. It also introduces a dependency on `cargo-binutils` with 166 merged. Note that PR has not yet been merged at time of writing. By default, this only tests LLVM 20, which is the latest version currently available on stable rust.
xd009642
approved these changes
Sep 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, testing all supported configurations required installing many different versions of rustc manually. Now, it only requires running
cargo test --all-features.This introduces a dependency on
rustup. It also introduces a dependency oncargo-binutilswith rust-embedded/cargo-binutils#166 merged.By default, this only tests LLVM 20, which is the latest version currently available on stable rust.
cc #57