Skip to content

remove try catch blocks, so that the actual exception (if any) can be seen in the test-explorer #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ndw merged 1 commit into from
Jan 9, 2026
Merged

remove try catch blocks, so that the actual exception (if any) can be seen in the test-explorer #85

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
63 changes: 21 additions & 42 deletions DataTests/ResolverTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,62 +43,41 @@ private XmlResolver.XmlResolver Resolver
[Test]
public void LookupSystem()
{
try
{
Uri result = UriUtils.Resolve(TestRootDirectory, "DataTests/resources/sample10/sample.dtd");
var req = Resolver.GetRequest("https://example.com/sample/1.0/sample.dtd");
var resp = Resolver.Resolve(req);
Uri result = UriUtils.Resolve(TestRootDirectory, "DataTests/resources/sample10/sample.dtd");
var req = Resolver.GetRequest("https://example.com/sample/1.0/sample.dtd");
var resp = Resolver.Resolve(req);

Assert.That(resp.Stream, Is.Not.Null);
Assert.That(resp.Uri, Is.EqualTo(result));
}
catch (Exception)
{
Assert.Fail();
}
Assert.That(resp.Stream, Is.Not.Null);
Assert.That(resp.Uri, Is.EqualTo(result));
}

[Test]
public void LookupSystemAsUri()
{
try
{
Uri result = UriUtils.Resolve(TestRootDirectory, "DataTests/resources/sample10/sample.dtd");
var req = Resolver.GetRequest("https://example.com/sample/1.0/uri.dtd");
var resp = Resolver.Resolve(req);
Uri result = UriUtils.Resolve(TestRootDirectory, "DataTests/resources/sample10/sample.dtd");
var req = Resolver.GetRequest("https://example.com/sample/1.0/uri.dtd");
var resp = Resolver.Resolve(req);

Assert.That(resp.Stream, Is.Not.Null);
Assert.That(resp.Uri, Is.EqualTo(result));
}
catch (Exception)
{
Assert.Fail();
}
Assert.That(resp.Stream, Is.Not.Null);
Assert.That(resp.Uri, Is.EqualTo(result));
}

[Test]
public void SequenceTest()
{
try
{
var catalogs = new List<string>
var catalogs = new List<string>
{
TestRootPath + "/DataTests/resources/seqtest1.xml",
TestRootPath + "/DataTests/resources/seqtest2.xml"
};

XmlResolverConfiguration localConfig = new XmlResolverConfiguration(new List<Uri>(), catalogs);
localConfig.SetFeature(ResolverFeature.URI_FOR_SYSTEM, true);

XmlResolver.XmlResolver localResolver = new XmlResolver.XmlResolver(localConfig);
var req = localResolver.GetRequest("https://xmlresolver.org/ns/sample-as-uri/sample.dtd");
var resp = localResolver.Resolve(req);

Assert.That(resp.Stream, Is.Not.Null);
}
catch (Exception)
{
Assert.Fail();
}
};

XmlResolverConfiguration localConfig = new XmlResolverConfiguration(new List<Uri>(), catalogs);
localConfig.SetFeature(ResolverFeature.URI_FOR_SYSTEM, true);

XmlResolver.XmlResolver localResolver = new XmlResolver.XmlResolver(localConfig);
var req = localResolver.GetRequest("https://xmlresolver.org/ns/sample-as-uri/sample.dtd");
var resp = localResolver.Resolve(req);

Assert.That(resp.Stream, Is.Not.Null);
}
}