-
Notifications
You must be signed in to change notification settings - Fork 6
Use ArkEnv #221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use ArkEnv #221
Conversation
- Replaced env config with `arkenv` library - Updated `env.config.ts` to `arkenv
- Remove old `@/core/env` module - Update env import paths to use `@env` alias - Simplify environment variable resolution
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
WalkthroughMigrates the Conduit app from an Elysia-based env system to ArkEnv: replaces Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@apps/conduit/env.config.ts`:
- Around line 3-13: The current arkenv schema in env.config.ts defines
JWT_SECRET without a default, causing eager validation failures; remove
JWT_SECRET from this shared arkenv schema and create a separate auth-only env
module (e.g., auth.env.ts) that calls arkenv with JWT_SECRET as a required value
(no default), then update the authentication service to import JWT_SECRET from
the new auth.env.ts while leaving database/tooling code to import the original
env.config.ts (which may keep safe defaults for other vars); this decouples
tooling from app-only secrets (reference: arkenv export default, JWT_SECRET,
env.config.ts, and the new auth.env.ts module).
- Implement ArkEnv for robust environment validation - Update `conduit` app to use `env.PORT` - Add comprehensive documentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
apps/conduit/.env.example (1)
1-8: Consider reordering keys to satisfy dotenv-linter.This is a minor lint warning, but reordering avoids CI noise and keeps env files consistent.
♻️ Proposed ordering tweak
POSTGRES_USER=postgres POSTGRES_PASSWORD=postgres +PORT=3000 POSTGRES_DB=medium POSTGRES_HOST=0.0.0.0 POSTGRES_PORT=5432 JWT_SECRET=supersecretkey JWT_ALGORITHM=HS256 -PORT=3000
Description
Use ArkEnv for environment variables. Related to #213
PR Checklist
bun docsSummary by CodeRabbit
Refactor
Documentation
✏️ Tip: You can customize this high-level summary in your review settings.