Fixed commit hanging if commitOffset < readOffset#620
Merged
alex268 merged 1 commit intoydb-platform:masterfrom Apr 1, 2026
Merged
Fixed commit hanging if commitOffset < readOffset#620alex268 merged 1 commit intoydb-platform:masterfrom
alex268 merged 1 commit intoydb-platform:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #620 +/- ##
============================================
+ Coverage 69.49% 69.59% +0.09%
- Complexity 3167 3172 +5
============================================
Files 362 362
Lines 15455 15455
Branches 1628 1628
============================================
+ Hits 10741 10756 +15
+ Misses 4047 4033 -14
+ Partials 667 666 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a reader commit hang when a partition session is started with commitOffset < readOffset (e.g., when emulating retention / skipping old offsets), and re-enables the previously ignored integration test that was freezing in that scenario.
Changes:
- Adjusts
ReadPartitionSessioninitialization so commit-range tracking starts from the committed/commit offset rather than the read offset. - Updates
ReadSessionpartition-session creation to align with the newReadPartitionSessionconstructor semantics. - Re-enables
readRetentionedTopicTestby removing@Ignore.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
topic/src/test/java/tech/ydb/topic/impl/TopicReadersIntegrationTest.java |
Re-enables the retention/skip scenario integration test that previously froze. |
topic/src/main/java/tech/ydb/topic/read/impl/ReadSession.java |
Separates readFrom vs commitTo offsets and wires the partition session with the commit offset. |
topic/src/main/java/tech/ydb/topic/read/impl/ReadPartitionSession.java |
Changes constructor and initializes internal offset tracking from the committed/commit offset to prevent commit hangs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
pnv1
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.