Conversation
9638dde to
fffcbbf
Compare
There was a problem hiding this comment.
Pull request overview
This PR updates the topic writer’s asyncio reconnector to send queued messages in larger batches (instead of one gRPC write per message), and extends test coverage to validate batching and request-splitting behavior.
Changes:
- Batch sends in
WriterAsyncIOReconnector._send_loopby draining_new_messagesand callingwriter.write()once per batch. - Update asyncio reconnector tests to expect batched sends and batched re-sends after reconnect.
- Add unit tests for
_split_messages_for_send()andmessages_to_proto_requests()(codec-run grouping + max gRPC size splitting).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
ydb/_topic_writer/topic_writer_asyncio.py |
Batch messages in the reconnector send loop to reduce per-message write calls. |
ydb/_topic_writer/topic_writer_asyncio_test.py |
Adjust expectations for batched sends; add batching-focused tests. |
ydb/_topic_writer/topic_writer_test.py |
Add unit tests for message grouping/splitting into proto write requests. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
rekby
approved these changes
Apr 1, 2026
fffcbbf to
c9eb77d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Other information