Conversation
Member
Tigrov
commented
May 19, 2026
Tigrov
commented
| Q | A |
|---|---|
| Is bugfix? | ✔️ |
| New feature? | ❌ |
| Breaks BC? | ❌ |
| Issue | #338 |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #341 +/- ##
============================================
- Coverage 12.66% 0.00% -12.67%
- Complexity 300 303 +3
============================================
Files 20 20
Lines 963 977 +14
============================================
- Hits 122 0 -122
- Misses 841 977 +136 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
vjik
requested changes
May 19, 2026
Member
vjik
left a comment
vjik
left a comment
There was a problem hiding this comment.
Add test with two namespaces pointing to the same directory and create in this directory two migration with different namespaces.
Comment on lines
+446
to
+452
| if (!is_dir($sourcePath)) { | ||
| throw new LogicException("Invalid path directory \"$sourcePath\""); | ||
| } | ||
|
|
||
| $sourcePath = rtrim(str_replace('\\', '/', $sourcePath), '/'); | ||
| $sourceNamespace = $this->getNamespacesFromPath($sourcePath)[0] ?? ''; | ||
| $paths[$sourcePath] = $sourceNamespace; |
Member
There was a problem hiding this comment.
This code is duplicated above. Maybe extract it to separate private method?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.