Add Glob support for dictionary includes#1477
Add Glob support for dictionary includes#1477Lutzifer wants to merge 5 commits intoyonaskolb:masterfrom
Conversation
This change enables the use of Glob expressions (e.g. Sources/*/Package.yml) when including a yml file: ``` include: - path: Sources/*/Package.yml - path: Sources/*/Tests.yml - path: Sources/*/UITests.yml ```
yonaskolb
left a comment
yonaskolb
left a comment
There was a problem hiding this comment.
Would love to see some tests for this in SpecLoadingTests
|
|
||
| private static func includes(from array: [Any], basePath: Path) -> [Include] { | ||
| array.flatMap { entry -> [Include] in | ||
| if let string = entry as? String, let include = Include(any: string) { |
There was a problem hiding this comment.
If I'm reading this right only includes defined as a dictionary will be glob enabled, whereas plain strings won't?
There was a problem hiding this comment.
yeah, I wanted to keep the changes as isolated to my use case as possible.
But I can have a look at extending it if you want to
There was a problem hiding this comment.
started working on this, but still ironing out some stuff
There was a problem hiding this comment.
If I understand, I see you've added support for a single string include, but not arrays of strings (where this line is). In breaking 3.0 version, support for these simpler strings could probably be dropped in the future.
Also ideally the glob logic would only be in one place where currently it is split across parse(json:) and includes(from:,basePath:)
I implemented a very basic test for this |
|
@yonaskolb Anything I can do here? |
2 participants
This change enables the use of Glob expressions (e.g. Sources/*/Package.yml) when including a yml file: