Provide swiped position to onCardSwiped event#292
Open
Barryrowe wants to merge 1 commit intoyuyakaido:masterfrom
Open
Provide swiped position to onCardSwiped event#292Barryrowe wants to merge 1 commit intoyuyakaido:masterfrom
Barryrowe wants to merge 1 commit intoyuyakaido:masterfrom
Conversation
Whenever a card is swiped, this also captures the position of the swiped card and emits it to the event. This allows us to trust the position at the event handler, and not have to inspect the cardLayoutManager directly. This is helpful in the case where our event may trigger another runnable or otherwise may not be able to trust that the layoutManager has not already calculated another topPosition.
muramrr
approved these changes
Nov 3, 2019
|
Please merge this, I had exactly the problem Barryrowe described as possible issue |
andreste
approved these changes
Aug 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Whenever a card is swiped, this also captures the position
of the swiped card and emits it to the event. This allows
us to trust the position at the event handler, and not have
to inspect the cardLayoutManager directly. This is helpful
in the case where our event may trigger another runnable or
otherwise may not be able to trust that the layoutManager
has not already calculated another topPosition.