Skip to content

fix(labels): support older Ruby hash iteration #431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ss-o merged 1 commit into from
May 27, 2026
Merged

fix(labels): support older Ruby hash iteration #431

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions scripts/labels-sync.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,7 @@ def diff_repo(owner_repo, canonical, legacy_migrations)

missing = canonical.keys.reject { |name| live_by_name.key?(name) }

updates = canonical.filter_map do |name, desired|
updates = canonical.each_with_object([]) do |(name, desired), items|
current = live_by_name[name]
next unless current

Expand All @@ -249,13 +249,13 @@ def diff_repo(owner_repo, canonical, legacy_migrations)
if current.fetch("description") != desired.fetch("description")
changes["description"] = { "current" => current.fetch("description"), "desired" => desired.fetch("description") }
end
changes.empty? ? nil : { "name" => name, "changes" => changes }
items << { "name" => name, "changes" => changes } unless changes.empty?
end

legacy_present = legacy_migrations.filter_map do |legacy, replacement|
legacy_present = legacy_migrations.each_with_object([]) do |(legacy, replacement), items|
next unless live_by_name.key?(legacy)

{ "legacy" => legacy, "replacement" => replacement }
items << { "legacy" => legacy, "replacement" => replacement }
end

unknown = live_by_name.keys.reject do |name|
Expand Down