Skip to content

fix(trunk): quote runs-on input reference#434

Merged
ss-o merged 1 commit into
mainfrom
bug-408-fix-trunk-runs-on-input
Jun 1, 2026
Merged

fix(trunk): quote runs-on input reference#434
ss-o merged 1 commit into
mainfrom
bug-408-fix-trunk-runs-on-input

Conversation

@ss-o
Copy link
Copy Markdown
Member

@ss-o ss-o commented Jun 1, 2026

Summary

  • use bracket notation for the hyphenated reusable-workflow runs-on input
  • restore validation for callers of the organization Trunk workflow

Evidence

New callers failed before job creation with zero jobs. The reusable workflow used ${{ inputs.runs-on }}, while all other hyphenated inputs correctly use bracket notation.

Verification

  • YAML parse with Ruby Psych
  • git diff --check
  • scan for hyphenated inputs.*-* dot notation

Tracks #408.

@ss-o ss-o marked this pull request as ready for review June 1, 2026 04:41
@ss-o ss-o requested a review from a team as a code owner June 1, 2026 04:41
Copilot AI review requested due to automatic review settings June 1, 2026 04:41
@ss-o ss-o merged commit adfd5fd into main Jun 1, 2026
2 checks passed
@ss-o ss-o deleted the bug-408-fix-trunk-runs-on-input branch June 1, 2026 04:41
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Updates the GitHub Actions workflow to correctly reference an input whose name contains a hyphen, ensuring the runs-on expression evaluates properly.

Changes:

  • Switched from dot-notation to bracket-notation when reading the runs-on input.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants