Add retry logic to role synchronization#3100
Open
jorsol wants to merge 1 commit into
Open
Conversation
Member
|
syncing roles is not the only time write operations happen. How about implementing a retry logic around db.Exec(query) parts in users.go file like you've mentioned in your issue. Search for: to see how it was done in other places. |
2cb0f47 to
dc147e3
Compare
Contributor
Author
|
Hi @FxKu, can you review again? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevents
syncRoles()from failing during cluster startup, crash recovery, or primary failover windows.When a PostgreSQL instance is starting up or processing WAL logs, it will accept connections but reject write operations with a
26006read-only transaction error. Since role syncing occurs within a reconciliation loop, failing flat during this phase creates unnecessary error noise.This adds a retry logic around
c.userSyncStrategy.ExecuteSyncRequeststo not fail immediately.Closes #3099