Ensure TCP connections are properly closed#152
Merged
thc202 merged 1 commit intozaproxy:mainfrom Dec 9, 2025
Merged
Conversation
Member
|
Great job! No new security vulnerabilities introduced in this pull requestUse @Checkmarx to reach out to us for assistance. Just send a PR comment with Examples: |
thc202
approved these changes
Dec 9, 2025
Member
|
Thank you! |
psiinon
approved these changes
Dec 9, 2025
Use a context-managed `requests.Session` to guarantee that the session and its underlying TCP connections are properly closed. This prevents `ResourceWarning` messages being written to stderr. Signed-off-by: Moritz Duchêne <debakel@users.noreply.github.com>
Member
|
Pushed to trigger the checks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use a context-managed
requests.Sessionto guarantee that the session and its underlying TCP connections are properly closed.This prevents
ResourceWarningmessages being written to stderr.