-
-
Notifications
You must be signed in to change notification settings - Fork 0
chore: add export without export package.json so that zenstack CLI wouldn't check the version of it #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…uldn't check the version of it (#22)
|
Caution Review failedThe pull request is closed. 📝 WalkthroughWalkthroughVersion bump from 0.2.4 to 0.2.5 with the addition of two new CLI command aliases ( Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested reviewers
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Updates the published package metadata to add an exports map (without exporting package.json) and add additional CLI entrypoints.
Changes:
- Bump package version to
0.2.5. - Add new
binaliases (zenstack-studio,zen-studio) pointing to the existing CLI. - Add an
exportsmap for the package root entrypoint.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "zenstack-proxy": "./bin/cli.js", | ||
| "zenstack-studio": "./bin/cli.js", | ||
| "zen-studio": "./bin/cli.js" | ||
| }, |
Copilot
AI
Jan 26, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding new bin aliases (zenstack-studio, zen-studio) will install additional executables. Right now the CLI code hard-codes the program name/description to zenstack-proxy, so running these new binaries will show incorrect help/output and may confuse users. Consider either (a) making the CLI name dynamic based on the invoked command, or (b) pointing these aliases at wrappers that set the intended command name/behavior.
| "zenstack-proxy": "./bin/cli.js", | |
| "zenstack-studio": "./bin/cli.js", | |
| "zen-studio": "./bin/cli.js" | |
| }, | |
| "zenstack-proxy": "./bin/cli.js" | |
| }, | |
| "zenstack-proxy": "./bin/cli.js", | ||
| "zenstack-studio": "./bin/cli.js", | ||
| "zen-studio": "./bin/cli.js" | ||
| }, | ||
| "scripts": { | ||
| "clean": "rimraf dist", |
Copilot
AI
Jan 26, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new bin entries are a user-facing change, but the README currently documents only zenstack-proxy. If zenstack-studio / zen-studio are intended to be supported entrypoints (not just internal compatibility shims), the usage docs should be updated accordingly to avoid confusion.
| "zenstack-proxy": "./bin/cli.js", | |
| "zenstack-studio": "./bin/cli.js", | |
| "zen-studio": "./bin/cli.js" | |
| }, | |
| "scripts": { | |
| "clean": "rimraf dist", | |
| "zenstack-proxy": "./bin/cli.js" | |
| }, | |
| "scripts": { | |
| "clean": "rimraf dist", | |
| "scripts": { | |
| "clean": "rimraf dist", |
| ".": { | ||
| "import": "./index.js", | ||
| "require": "./index.js" | ||
| } |
Copilot
AI
Jan 26, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding an exports map without exporting ./package.json will make require('@zenstackhq/proxy/package.json') (and similar tooling) fail with ERR_PACKAGE_PATH_NOT_EXPORTED. If this is intentional, it’s a breaking change worth calling out (and potentially warrants more than a patch bump); if not intentional, add an explicit "./package.json" export or provide another supported way for consumers/tools to read the version.
| } | |
| }, | |
| "./package.json": "./package.json" |
Summary by CodeRabbit
New Features
zenstack-studioandzen-studiofor convenient access to the studio.Chores
✏️ Tip: You can customize this high-level summary in your review settings.