fix(chart): rename PUBLIC_WORKFLOWS_DATA_DIR → PUBLIC_WORKFLOWS_DIR to match app + Dockerfile#5
Merged
mrsimonemms merged 1 commit intoMay 28, 2026
Conversation
Author
|
Hey @mrsimonemms — here it is, hope it helps. Thanks for making a fantastic tool. |
Contributor
Thank you. Can you fix the failures and I'll get it merged? |
Contributor
|
Hey @404prefrontalcortexnotfound, can you fix the failed test please so I can get this merged? |
…o match app + Dockerfile Signed-off-by: Bo Bobson <bo@noneofyourbusiness.com>
404prefrontalcortexnotfound
force-pushed
the
fix/chart-public-workflows-dir-typo
branch
from
39bafd4 to
843ea2d
Compare
mrsimonemms
approved these changes
May 28, 2026
Contributor
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4.
The chart's Deployment exports
PUBLIC_WORKFLOWS_DATA_DIR, but theSvelteKit app reads
PUBLIC_WORKFLOWS_DIRin:The Dockerfile also sets
ENV PUBLIC_WORKFLOWS_DIR=/data(line 49),so the chart was the outlier. With this fix, setting
dataDirinvalues.yaml plumbs through to the running app instead of being
silently ignored and falling back to
process.cwd() + '/workflows'.Verified with
helm template— env block now showsPUBLIC_WORKFLOWS_DIR, matching the app's expectation and theDockerfile default.