Fix: topic_segment=False no longer skips memory pipeline + defensive fixes#63
Open
keketcl wants to merge 3 commits into
Open
Fix: topic_segment=False no longer skips memory pipeline + defensive fixes#63keketcl wants to merge 3 commits into
keketcl wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix
topic_segment=Falsenot creating any memories, plus additional improvements.Changes
From PR #59 (preserved)
Bug 1 (critical):
topic_segment=Falseskipped entire memory pipeline — fix replaces early return with single-segment fallback.Bug 2 (guard):
force_segment=True+topic_segment=Falsecrashed due to uninitialized segmenter — fix adds guard condition.Added in this PR
Bug 3 (defensive init): When
metadata_generate=Falseortext_summary=False, theextracted_resultsvariable was never assigned, causingNameError. This was previously hidden by Bug 1's early return and exposed after PR #59's fix removed that early return.Fix: Initialize
extracted_results = []before the conditional block.Doc improvements
add_memorydocstring to reflect new behavior (single-segment fallback, no early return)Notessection: remove outdated "returns early" descriptionReturnssection: remove outdated segmentation result dict formatTesting
Tested with
topic_segment=False+metadata_generate=False+text_summary=False: