fix: allow add_memory() to work when topic_segment=False#64
Open
li5435945-ship-it wants to merge 1 commit into
Open
fix: allow add_memory() to work when topic_segment=False#64li5435945-ship-it wants to merge 1 commit into
li5435945-ship-it wants to merge 1 commit into
Conversation
When topic_segment=False, add_memory() returned early before performing any LLM extraction, resulting in zero memory entries being stored in the vector database. This made it impossible to use LightMem without the LLMlingua-2 model. Fix: When topic_segment is disabled, treat all messages as a single segment and proceed with the normal extraction pipeline. Fixes zjunlp#55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When topic_segment=False is set in the configuration, add_memory() returns early before performing any LLM extraction, resulting in zero memory entries being stored in the vector database.
Fixes #55
Solution
When topic_segment=False, treat all messages as a single segment and proceed with the normal extraction pipeline.
Changes