Without facades by zombyacoff · Pull Request #6 · zombyacoff/faceit-python

zombyacoff · 2026-03-19T07:22:53Z

Summary by cubic

Removed the old facades and made SyncDataResource / AsyncDataResource the primary API. This simplifies client setup, improves pagination typing, upgrades SkillLevel behavior, standardizes retries around APIError, and refreshes the README. Version bumped to 0.2.0b1.

Refactors
- SyncDataResource / AsyncDataResource are the main entry; Faceit / AsyncFaceit remain but are deprecated.
- Centralized client init in faceit.resources.aggregator.
- Pagination: iterators now use protocol types; gather_pages returns ItemPage[...] for models and list for raw. Removed MaxPages; use pages(...).
- ItemPage adds get_first / get_last / get_random (aliases first/last/random kept).
- HTTP: unified retries via tenacity; retry on and raise APIError for server errors; better SSL handling; masked API key now shows prefix/suffix.
- Models: GameInfo.skill_level auto-converts to SkillLevel; SkillLevel supports equality and ordering.
- Endpoints: reverted strict type checks in division operators to previous behavior.
- Cleanup: removed outdated examples and Taskfile.yml; README restored with basic usage docs.
Migration
- Replace Faceit.data(...) with SyncDataResource(...) and AsyncFaceit.data(...) with AsyncDataResource(...) (accept an API key or a prebuilt client).
- Replace MaxPages(...) with pages(...).
- Prefer get_first / get_last / get_random on ItemPage (old names still work).
- Replace matches.details(...) and teams.details(...) with get(...).
- If you read GameInfo.skill_level as an int, cast it: int(info.level).
- If you compare client.api_key, expect a masked prefix/suffix instead of [REDACTED].
- If you previously caught httpx.HTTPStatusError, catch APIError instead.

^{Written for commit b027dc4. Summary will update on new commits.}

zombyacoff · 2026-03-19T07:25:25Z

@cubic-dev-ai review this

cubic-dev-ai · 2026-03-19T07:25:36Z

@cubic-dev-ai review this

@zombyacoff I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

4 issues found across 37 files

Prompt for AI agents (unresolved issues)


Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="src/faceit/resources/aggregator.py">

<violation number="1" location="src/faceit/resources/aggregator.py:91">
P1: `NullCallable().__call__` returns `self` (truthy), so using it as `__exit__` will silently suppress all exceptions inside a `with` block. The context manager protocol interprets a truthy `__exit__` return as "suppress the exception". Consider using a dedicated no-op that returns `None`, or override `__exit__` with a proper method.</violation>
</file>

<file name="src/faceit/models/players/general.py">

<violation number="1" location="src/faceit/models/players/general.py:43">
P2: `SkillLevel.get_level()` can return `None`, which would replace a valid integer `skill_level` with `None` and cause a validation error on a non-optional field. Guard against this by only assigning the result when it's not `None`.</violation>
</file>

<file name="src/faceit/faceit.py">

<violation number="1" location="src/faceit/faceit.py:10">
P1: `@deprecated` on `BaseFaceit` causes a `DeprecationWarning` to be emitted at import time whenever `Faceit` or `AsyncFaceit` subclass definitions are evaluated. Every user who does `import faceit` will see spurious deprecation warnings they cannot suppress.

Since `BaseFaceit` is an internal class not meant for external subclassing, remove the `@deprecated` decorator from it. The `@deprecated` on `Faceit`/`AsyncFaceit` is sufficient to signal deprecation to static type checkers.</violation>
</file>

<file name="src/faceit/models/item_page.py">

<violation number="1" location="src/faceit/models/item_page.py:133">
P2: `typing.Generator[_T]` requires 3 type parameters on Python < 3.13 (this project supports >=3.8). The previous `typing.Iterator[_T]` was correct, or use the full form `typing.Generator[_T, None, None]` to match the pattern used elsewhere in this codebase (e.g., `pagination.py`).</violation>
</file>

Since this is your first cubic review, here's how it works:

cubic automatically reviews your code and comments on bugs and improvements
Teach cubic by replying to its comments. cubic learns from your replies and gets better over time
Add one-off context when rerunning by tagging @cubic-dev-ai with guidance or docs links (including llms.txt)
Ask questions if you need clarification on any suggestion

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

src/faceit/resources/aggregator.py

src/faceit/faceit.py

src/faceit/models/players/general.py

src/faceit/models/item_page.py

zombyacoff · 2026-03-19T08:18:55Z

@cubic-dev-ai review bcfaf02

cubic-dev-ai · 2026-03-19T08:19:03Z

@cubic-dev-ai review bcfaf02

@zombyacoff I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

2 issues found across 39 files

Prompt for AI agents (unresolved issues)


Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="src/faceit/models/item_page.py">

<violation number="1" location="src/faceit/models/item_page.py:162">
P1: `reversed(self)` inside `__reversed__` causes infinite recursion. Use `reversed(self.items)` to reverse the underlying tuple directly.</violation>
</file>

<file name="src/faceit/models/players/general.py">

<violation number="1" location="src/faceit/models/players/general.py:50">
P2: Replace `assert` with an explicit `raise`. `assert` statements are removed when Python runs with `-O`/`-OO`, so this invariant check silently disappears in optimized mode.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

src/faceit/models/item_page.py

cubic-dev-ai · 2026-03-19T08:24:44Z

src/faceit/models/players/general.py

+            assert resolved is not None, (
+                "`resolved` cannot be None because `game_id` was already validated "
+                "to be present in `ELO_THRESHOLDS`"
+            )


P2: Replace assert with an explicit raise. assert statements are removed when Python runs with -O/-OO, so this invariant check silently disappears in optimized mode.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At src/faceit/models/players/general.py, line 50: <comment>Replace `assert` with an explicit `raise`. `assert` statements are removed when Python runs with `-O`/`-OO`, so this invariant check silently disappears in optimized mode.</comment> <file context> @@ -13,19 +14,51 @@ + and not isinstance(skill_lvl, SkillLevel) + ): + resolved = SkillLevel.get_level(game_id, skill_lvl) + assert resolved is not None, ( + "`resolved` cannot be None because `game_id` was already validated " + "to be present in `ELO_THRESHOLDS`" </file context>

Suggested change

assert resolved is not None, (

"`resolved` cannot be None because `game_id` was already validated "

"to be present in `ELO_THRESHOLDS`"

)

if resolved is None:

raise RuntimeError(

"`resolved` cannot be None because `game_id` was already validated "

"to be present in `ELO_THRESHOLDS`"

)

Не имеет смысла, т.к. я здесь просто даю знать стат. типизаторам и разработчикам, что все под контролем
@cubic-dev-ai

Thanks for the feedback! I've saved this as a new learning to improve future reviews.

Понял: здесь assert служит для инварианта/узкого типа для статических типизаторов, а не как рантайм‑проверка. Учту это в будущих ревью.

zombyacoff · 2026-03-20T19:03:37Z

@cubic-dev-ai review 851d780

cubic-dev-ai · 2026-03-20T19:04:36Z

@cubic-dev-ai review 851d780

@zombyacoff I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

2 issues found across 41 files

Prompt for AI agents (unresolved issues)


Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="src/faceit/http/helpers.py">

<violation number="1" location="src/faceit/http/helpers.py:84">
P2: `str(other)` succeeds for virtually all Python objects (int, None, list, etc.), so the `except (TypeError, ValueError)` block is practically unreachable and `UnsupportedOperationTypeError` will never be raised for common misuse. If someone accidentally passes `None` or an `int`, this silently builds a malformed endpoint (e.g. `".../None"`) instead of failing fast.

If the intent is to accept any stringable object, update `EndpointParam` to reflect that. If only `str` and `Endpoint` are valid, restore the explicit `isinstance(other, str)` check before calling `self.add()`.</violation>
</file>

<file name="src/faceit/models/players/general.py">

<violation number="1" location="src/faceit/models/players/general.py:185">
P2: `total_sniper_kills` field is present in the old `LifetimeStats` and in the sibling `CSMapStats` model, but was dropped from `CSLifetimeStats`. This looks like an accidental omission during the refactor — API consumers lose access to this stat.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

src/faceit/http/helpers.py

src/faceit/models/players/general.py

Replace try/except str(other) with isinstance(other, str) in both __truediv__ and __itruediv__ so that non-str, non-Endpoint values (e.g. None, int) raise UnsupportedOperationTypeError instead of silently building malformed endpoints.

…tors" This reverts commit a76e446.

zombyacoff added 9 commits November 17, 2025 20:05

refactor: facades

7d67f5e

refactor: remove main facade

d7fdeca

chore: remove outdated examples

487463c

refactor: fix typing

e55c76a

fix: readme file in build

ec9d4c8

fix: readme file again to md

f006d82

refactor: facade backward compatibility

f151444

style: import from http directly

b9421e9

feat: implement automatic SkillLevel conversion

2359e8c

zombyacoff linked an issue Mar 19, 2026 that may be closed by this pull request

Deprecation of facades in future versions #5

Open

cubic-dev-ai bot reviewed Mar 19, 2026

View reviewed changes

src/faceit/resources/aggregator.py Outdated Show resolved Hide resolved

src/faceit/faceit.py Outdated Show resolved Hide resolved

src/faceit/models/players/general.py Outdated Show resolved Hide resolved

src/faceit/models/item_page.py Outdated Show resolved Hide resolved

feat: add comparison operators to SkillLevel

bcfaf02

cubic-dev-ai bot reviewed Mar 19, 2026

View reviewed changes

refactor: retry on APIError instead of httpx.HTTPStatusError

851d780

cubic-dev-ai bot reviewed Mar 20, 2026

View reviewed changes

src/faceit/http/helpers.py Show resolved Hide resolved

src/faceit/models/players/general.py Show resolved Hide resolved

cubic-dev-ai[bot] and others added 3 commits March 21, 2026 04:02

Revert "fix: use explicit isinstance check in Endpoint division opera…

7946a56

…tors" This reverts commit a76e446.

docs: add readme

b027dc4

Conversation

zombyacoff commented Mar 19, 2026 • edited by cubic-dev-ai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by cubic

Uh oh!

zombyacoff commented Mar 19, 2026

Uh oh!

cubic-dev-ai bot commented Mar 19, 2026

Uh oh!

cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

zombyacoff commented Mar 19, 2026

Uh oh!

cubic-dev-ai bot commented Mar 19, 2026

Uh oh!

cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cubic-dev-ai bot Mar 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

zombyacoff Mar 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai bot Mar 19, 2026

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai bot Mar 19, 2026

Choose a reason for hiding this comment

Uh oh!

zombyacoff commented Mar 20, 2026

Uh oh!

cubic-dev-ai bot commented Mar 20, 2026

Uh oh!

cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

zombyacoff commented Mar 19, 2026 •

edited by cubic-dev-ai bot

Loading

cubic-dev-ai bot Mar 19, 2026 •

edited

Loading

zombyacoff Mar 19, 2026 •

edited

Loading