Key Reference String Table Generation Feature + UI Refinements#38
Key Reference String Table Generation Feature + UI Refinements#38Crezetique wants to merge 8 commits into
Conversation
|
Hello. Thank you for the contribution! The idea of generating String Tables sounds good, but somehow I've never thought about it. Let's work on this PR with the UI changes. It will take me some time to check if everything works as intended (not having much time lately, you can figured it out by the tempo I reply :D ). I introduced some changes to this PR:
Next time I wiill sit to it I will check if everything works in different combinations and on all engine versions. So it will take some time :) Once again, thank you very much for the input! |
|
Hey~ Glad to know my changes are well received. Having only recently adopted this plugin, I have to thank you for the work you've already poured into it. I totally understand the time required to ensure the changes are functional in all supported versions, it is most commendable really!
3-5. I have reviewed your changes. Hopefully I'll pick up on the standards quickly 😅 I'll go ahead and merge the pull request description, so we may close the other thread. |
…lder versions of UE. - Replaced FillContentWidth() with .FillWidth(1.0f), as the former is not supported in older versions. - Nested various content in SBox as SVerticalBox and SHorizontalBox does not support .MinHeight() in older versions.
|
Hey @zompi2, I've went ahead and ran a build test for all version of UE5 (excluding 5.3) and resolve errors preventing the compilation on older UE5 version. Unfortunately this meant having to nest SHorizontalRows with an additional SBox in the widget, which made the commit hard to read. (6bd9957) I don't have UE4.27 installed, so if I may leave that to you for verification. |
Fixed message dialog call for older engine versions Co-authored-by: Ryan Lim <crezetique@gmail.com>
- Fixed GitHub auto commit being incorrectly done. - Fixed Key Column index not correctly defined. - Fixed StringTable package load causing assertion.
|
Did a major refactor of the import function (finally, it should be done long time ago). |
|
Now I just need to do all tests and... then submit :D Pfew! |
Goal & Purpose
There is unnecessary friction in manually inputting Localization Keys to the text field, namespace and key. ELT already works with String Table, this PR aims to seamlessly generate a String Table filled with Localization Keys. This also greatly reduces human error in manual key input.
Upon CSV Import, a String Table filled with Key References will be generated PER namespace.
The String Table will be generated in the Localization Folder path, it follows the full folder deletion and creation behavior, meaning they are not intended to be edited outside of ELT's management.
Changelog
Compatibility