Updated pool and util to support p2sh-segwit type of address#196
Open
gaurav-12 wants to merge 1 commit intozone117x:masterfrom
Open
Updated pool and util to support p2sh-segwit type of address#196gaurav-12 wants to merge 1 commit intozone117x:masterfrom
gaurav-12 wants to merge 1 commit intozone117x:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added support for p2sh-segwit address.
While setting up for my test mining pool, I faced the issue of block rewards going to random addresses when using p2sh-segwit, so had to use legacy address. Thanks to this reply and after confirming from this golang adaption, added the support.
The changes are tested locally and confirmed to be working as expected.
Thanks