Skip to content

Fix getting CBS Token during BIOS boot #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aasboddu merged 1 commit into from
Feb 9, 2026
Merged

Fix getting CBS Token during BIOS boot #52

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 29 additions & 3 deletions redfish-core/lib/bios.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,28 @@ inline BiosAttrMap JsonToBiosAttributes(const nlohmann::json& j)

return iMap;
}

/**
* @brief Check for allowed IP Addresses for usbvNic interface
*
**/
inline bool isAllowedIpAddress(const crow::Request& req)
{
const std::string ipStr = req.ipAddress.to_string();

constexpr std::string_view usbVnic1 = "::ffff:192.168.31.1";
constexpr std::string_view usbVnic2 = "::ffff:192.168.31.2";

if (ipStr == usbVnic1 || ipStr == usbVnic2)
{
BMCWEB_LOG_WARNING(
"Reject request from usbvNIC");
return false;
}

return true;
}

/**
* @brief Retrieves all CBS attributes data over DBus function
*
Expand Down Expand Up @@ -101,9 +123,13 @@ inline void
std::format("/redfish/v1/Systems/{}/Bios/Actions/Bios.ResetBios",
BMCWEB_REDFISH_SYSTEM_URI_NAME);

// Get the ActiveSoftwareImage and SoftwareImages
sw_util::populateSoftwareInformation(asyncResp, sw_util::biosPurpose, "",
true);
if (isAllowedIpAddress(req))
{
// Get the ActiveSoftwareImage and SoftwareImages
sw_util::populateSoftwareInformation(asyncResp, sw_util::biosPurpose, "",
true);
}

asyncResp->res.jsonValue["Attributes"] = nlohmann::json::object();

crow::connections::systemBus->async_method_call(
Expand Down