Skip to content

fix: check camelCase and snake_case for announcement push campaign ID#14027

Merged
dylanjeffers merged 2 commits intomainfrom
fix/announcement-campaign-tracking
Mar 31, 2026
Merged

fix: check camelCase and snake_case for announcement push campaign ID#14027
dylanjeffers merged 2 commits intomainfrom
fix/announcement-campaign-tracking

Conversation

@dylanjeffers
Copy link
Copy Markdown
Contributor

Summary

  • extractNotificationCampaignIdFromPayload in packages/mobile/src/notifications.ts only checked for notification_campaign_id (snake_case), but the AnnouncementPushNotification type uses notificationCampaignId (camelCase) — so announcement push campaign clicks were never tracked
  • Same fix applied to readNotificationCampaignId in packages/web/public/scripts/sw.js

Both extractors now check for both key forms so neither mobile nor web silently drops campaign IDs from announcement notifications.

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Mar 31, 2026

⚠️ No Changeset found

Latest commit: 7605b44

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Copy Markdown
Contributor

🌐 Web preview ready

Preview URL: https://audius-web-preview-pr-14027.audius.workers.dev

Unique preview for this PR (deployed from this branch).
Workflow run

@dylanjeffers dylanjeffers merged commit f755472 into main Mar 31, 2026
14 checks passed
@dylanjeffers dylanjeffers deleted the fix/announcement-campaign-tracking branch March 31, 2026 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant