fix: check camelCase and snake_case for announcement push campaign ID#14027
Merged
dylanjeffers merged 2 commits intomainfrom Mar 31, 2026
Merged
fix: check camelCase and snake_case for announcement push campaign ID#14027dylanjeffers merged 2 commits intomainfrom
dylanjeffers merged 2 commits intomainfrom
Conversation
|
Contributor
🌐 Web preview readyPreview URL: https://audius-web-preview-pr-14027.audius.workers.dev Unique preview for this PR (deployed from this branch). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
extractNotificationCampaignIdFromPayloadinpackages/mobile/src/notifications.tsonly checked fornotification_campaign_id(snake_case), but theAnnouncementPushNotificationtype usesnotificationCampaignId(camelCase) — so announcement push campaign clicks were never trackedreadNotificationCampaignIdinpackages/web/public/scripts/sw.jsBoth extractors now check for both key forms so neither mobile nor web silently drops campaign IDs from announcement notifications.