Skip to content

fix: check camelCase and snake_case for announcement push campaign ID #14027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dylanjeffers merged 2 commits into from
Mar 31, 2026
+10 −10
Merged

fix: check camelCase and snake_case for announcement push campaign ID #14027

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b514740
fix: check both camelCase and snake_case for announcement push campai…
dylanjeffers Mar 31, 2026
7605b44
Fixing lint and stuff
dylanjeffers Mar 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/mobile/src/notifications.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ function extractNotificationCampaignIdFromPayload(
const target = payload?.data?.data ?? payload?.data ?? payload ?? undefined
if (!target || typeof target !== 'object') return undefined
const o = target as Record<string, unknown>
const v = o.notification_campaign_id
const v = o.notification_campaign_id ?? o.notificationCampaignId
return typeof v === 'string' && v.length > 0 ? v : undefined
}

Expand Down
2 changes: 1 addition & 1 deletion packages/web/public/scripts/sw.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
function readNotificationCampaignId(raw) {
const target = raw?.data?.data ?? raw?.data ?? raw
if (!target || typeof target !== 'object') return null
const v = target.notification_campaign_id
const v = target.notification_campaign_id ?? target.notificationCampaignId
return typeof v === 'string' && v.length > 0 ? v : null
}

Expand Down
16 changes: 8 additions & 8 deletions packages/web/src/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,12 @@
// Handle stale chunk errors after deploys by reloading once
import 'setimmediate'

import { createRoot } from 'react-dom/client'

import './index.css'
import RootWithProviders from 'ssr/RootWithProviders'
import { registerErrorHmrHandler } from 'utils/hmr/errorHmrHandler'

window.addEventListener('vite:preloadError', (event) => {
event.preventDefault()

Expand All @@ -13,14 +21,6 @@ window.addEventListener('vite:preloadError', (event) => {
}
})

import 'setimmediate'

import { createRoot } from 'react-dom/client'

import './index.css'
import RootWithProviders from 'ssr/RootWithProviders'
import { registerErrorHmrHandler } from 'utils/hmr/errorHmrHandler'

// @ts-ignore
window.global ||= window

Expand Down
Loading