chore: test re-enabling early mem2reg pass #19871
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
…eactivate-mem2reg
Collaborator
Flakey Tests🤖 says: This CI run detected 1 tests that failed, but were tolerated due to a .test_patterns.yml entry. |
This was referenced Jan 26, 2026
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 27, 2026
…c-up bootstrap (#19945) If I want to test a patch in the Noir submodule against CI by altering `noir/noir-repo` directly rather than needing a new temporary tag it is currently not possible. When aztec-up [fetchs the versions](https://github.com/AztecProtocol/aztec-packages/blob/0bee1eb2dba5ed7d0b88466ae8ab58b9177dceb1/aztec-up/bootstrap.sh#L8) the `noir_version` expects an exact match for the tag. This prevents being able to directly modify the submodule as no tag exists. I ran into this issue in #19871 where CI would fail with `fatal: no tag exactly matches '515b2702975fd85069fae48ddd0d90a56cd65628'` at `aztec-up/bootstrap.sh`. This does not affect release builds as those are also protected in the [Noir build](https://github.com/AztecProtocol/aztec-packages/blob/f94d8e86e88ad812c50a2661f63fedc30c59a04b/noir/bootstrap.sh#L98).
Contributor
Author
|
Closing as tests are passing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE
Testing out reverting noir-lang/noir#9987 as I am getting a passing lest locally.