Skip to content

🔧 Sync rum-events-format with WebSocket resource schema#4716

Draft
bdibon wants to merge 1 commit into
boris.dibon/ws-2-observablefrom
boris.dibon/ws-3-events-format-types
Draft

🔧 Sync rum-events-format with WebSocket resource schema#4716
bdibon wants to merge 1 commit into
boris.dibon/ws-2-observablefrom
boris.dibon/ws-3-events-format-types

Conversation

@bdibon
Copy link
Copy Markdown
Contributor

@bdibon bdibon commented Jun 3, 2026

Motivation

Add the websocket resource type and its fields to the RUM event format so WebSocket connections can be reported as resource events.

Blocked: depends on the upstream rum-events-format schema PR landing first. Kept in draft until then.

Changes

  • Bump the rum-events-format submodule to include the websocket resource sub-schema (d6ba7f7 -> a597e6d).
  • Regenerate rumEvent.types.ts and add the corresponding raw event shape in rawRumEvent.types.ts.
  • Add ResourceType.WEBSOCKET to the core resource utils.

Test instructions

yarn typecheck

Checklist

  • Tested locally
  • Tested on staging
  • Added unit tests for this change.
  • Added e2e/integration tests for this change.
  • Updated documentation and/or relevant AGENTS.md file

Copy link
Copy Markdown
Contributor Author

bdibon commented Jun 3, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@datadog-prod-us1-5
Copy link
Copy Markdown

datadog-prod-us1-5 Bot commented Jun 3, 2026

Pipelines  Tests

Fix all issues with BitsAI

⚠️ Warnings

🚦 1 Pipeline job failed

DataDog/browser-sdk | check-schemas   View in Datadog   GitLab

See error Untracked changes detected in telemetryEvent.types.ts. Ensure rum-events-format is synced.

ℹ️ Info

No other issues found (see more)

🧪 All tests passed
❄️ No new flaky tests detected

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 76.72% (+0.00%)

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: b589226 | Docs | Datadog PR Page | Give us feedback!

@cit-pr-commenter-54b7da
Copy link
Copy Markdown

cit-pr-commenter-54b7da Bot commented Jun 3, 2026

Bundles Sizes Evolution

📦 Bundle Name Base Size Local Size 𝚫 𝚫% Status
Rum 172.28 KiB 172.28 KiB 0 B 0.00%
Rum Profiler 7.88 KiB 7.88 KiB 0 B 0.00%
Rum Recorder 21.21 KiB 21.21 KiB 0 B 0.00%
Logs 54.80 KiB 54.80 KiB 0 B 0.00%
Rum Slim 130.18 KiB 130.18 KiB 0 B 0.00%
Worker 22.96 KiB 22.96 KiB 0 B 0.00%

@bdibon bdibon force-pushed the boris.dibon/ws-2-observable branch from 26c246e to 9763a7b Compare June 4, 2026 09:16
@bdibon bdibon force-pushed the boris.dibon/ws-3-events-format-types branch from 0b25435 to 5d05de3 Compare June 4, 2026 09:16
Co-authored-by: Cursor <cursoragent@cursor.com>
@bdibon bdibon force-pushed the boris.dibon/ws-3-events-format-types branch from 5d05de3 to b589226 Compare June 4, 2026 12:30
@bdibon bdibon force-pushed the boris.dibon/ws-2-observable branch from 9763a7b to 7b7708d Compare June 4, 2026 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant